Add golden regression for OVRTX GPU transform rendering - #7859
Draft
mataylor-nvidia wants to merge 1 commit into
Draft
mataylor-nvidia wants to merge 1 commit into
mataylor-nvidia wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reading GPU transforms with OVRTX 0.4 can intermittently corrupt textures in one of several camera outputs. Add a native GPU rendering regression that detects this corruption and passes with OVRTX 0.5.0.377615.
The test renders two 640 × 360 cameras, moves a sphere and cube over a checkerboard, then compares each of the final ten settled RGB frames with checked-in GPU-off golden images. Both cameras are checked because the affected render product can vary between processes. It uses the existing OVRTX pixel tolerance (RGB L2 > 10, at most 3% differing pixels), supports both output-key APIs, and saves failure images and renderer logs.
Includes a local USD fixture, Git LFS golden PNGs, reference provenance/regeneration instructions, and a test-only changelog fragment. Requires the existing
ovrtxandtestextras plus an RTX-capable CUDA GPU; no Isaac Sim runtime or remote scene assets.Draft / merge dependency: the repository still pins OVRTX 0.4.1.364340. This test intentionally fails with that runtime; it has no version-based skip or xfail. The dependency upgrade must be coordinated before merging. This PR does not change the runtime pin.
Validation
NVIDIA A40, driver 580.173.02. Maximum differing-pixel percentage across both cameras and all ten comparison frames; limit 3%:
uv run --frozen --no-sync python -m pytest source/isaaclab_ov/test/test_ovrtx_gpu_transforms_golden.py -q: verified the 0.4 failure.PYTHONPATH: passed in two independent processes.uv run --frozen --no-sync isaaclab -f: passed all repository pre-commit checks, including Git LFS pointers and changelog validation.UV_FROZEN=1 uv run --isolated --extra test -- make -C docs current-docs: unsuccessful. Source validation reported 14 duplicate object-description warnings from unchangedisaaclab.sim.schemas.schemas_cfgAPI documentation; the remaining HTML/code-highlighting generation was stopped after those warnings. The new test-fixture README is outside the Sphinx documentation tree.link to comparison gif, too large to upload to PR:
https://nvidia.enterprise.slack.com/files/U0724PHG22F/F0C2DPK9AHY/camera_1_comparison.gif
Type of change
Release backport
Checklist
.skipchangelog fragment for the touched packageCONTRIBUTORS.md