Conversation
Signed-off-by: Qian Lin <qianl@nvidia.com>
Signed-off-by: Qian Lin <qianl@nvidia.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify graph and variation configclass overrides behind one validated nested-dictionary utility. Keep typed Experiment construction on full Hydra composition.
Why this change?
Graph environment configs and variations both apply values to existing Isaac Lab configclasses, but maintain separate override machinery. Variation composition also initializes dynamic Hydra schemas and clears global Hydra state even when typed Runs already provide a nested dictionary.
Typed Experiments solve a different problem. They construct environment, policy, Run, and Experiment dataclasses with selectors, interpolation, and Hydra override operators, so they should retain native Hydra composition.
What changes?
apply_env_cfg_overrideto the sharedapply_config_overrideutility._target_validation, typed configclass materialization, atomic validation, nested object identity, and Newton solver synchronization.VariationBase.apply_cfg.ConfigStore,hydra.compose, and shared-default dotlist merging for typed Experiments.The graph YAML field remains named
env_cfg_override. Hydra add/delete operators remain available for Experiment overrides; variation dotlist input supports assignments only.Usage example
Before:
After:
Validation
pre-commit run --all-filespasses in a clean worktree.SimulationApp.