Skip to content

Remove NGC login from CI/nightly and add isolated docker config #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterd-NV merged 2 commits into from
Aug 18, 2026
Merged

Remove NGC login from CI/nightly and add isolated docker config #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
137c5a1
remove ngc login
peterd-NV Aug 18, 2026
78169dc
add pip retry
peterd-NV Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,21 +87,15 @@ jobs:
git lfs install --local
git lfs pull

# Isaac Sim 6.0.1 on nvcr.io requires authenticated pull; anonymous
# access that worked for 6.0.0-dev2 is denied for this tag.
- name: Log in to NGC
- name: Run E2E tests
# The GPU runners are shared. Use an empty job-temporary Docker config so
# stale credentials cannot override anonymous access to the public base image,
# and this job cannot modify the runner's persistent Docker login.
env:
NGC_API_KEY: ${{ secrets.NGC_API_KEY }}
DOCKER_CONFIG: ${{ runner.temp }}/isaac-autodata-docker
run: |
if [ -z "${NGC_API_KEY}" ]; then
echo "NGC_API_KEY secret is empty; cannot pull nvcr.io/nvidia/isaac-sim"
exit 1
fi
# $oauthtoken is the literal NGC username.
echo "${NGC_API_KEY}" | docker login nvcr.io -u '$oauthtoken' --password-stdin

- name: Run E2E tests
run: ./scripts/ci/run_tests.sh
mkdir -p "${DOCKER_CONFIG}"
./scripts/ci/run_tests.sh

build_docs:
name: Build docs
Expand Down
20 changes: 7 additions & 13 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,21 +59,15 @@ jobs:
git lfs install --local
git lfs pull

# Isaac Sim 6.0.1 on nvcr.io requires authenticated pull; anonymous
# access that worked for 6.0.0-dev2 is denied for this tag.
- name: Log in to NGC
- name: Run full E2E suite
# The GPU runners are shared. Use an empty job-temporary Docker config so
# stale credentials cannot override anonymous access to the public base image,
# and this job cannot modify the runner's persistent Docker login.
env:
NGC_API_KEY: ${{ secrets.NGC_API_KEY }}
DOCKER_CONFIG: ${{ runner.temp }}/isaac-autodata-docker
run: |
if [ -z "${NGC_API_KEY}" ]; then
echo "NGC_API_KEY secret is empty; cannot pull nvcr.io/nvidia/isaac-sim"
exit 1
fi
# $oauthtoken is the literal NGC username.
echo "${NGC_API_KEY}" | docker login nvcr.io -u '$oauthtoken' --password-stdin

- name: Run full E2E suite
run: ./scripts/ci/run_tests.sh
mkdir -p "${DOCKER_CONFIG}"
./scripts/ci/run_tests.sh

- name: Test results summary
if: always()
Expand Down
4 changes: 4 additions & 0 deletions docker/Dockerfile.isaac_autodata
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ ENV WORKDIR=${WORKDIR}
WORKDIR "${WORKDIR}"

ENV TERM=xterm
# Tolerate transient package-index failures on shared CI runners. These settings
# are inherited by every pip invocation, including those run by isaaclab.sh.
ENV PIP_RETRIES=10 \
PIP_DEFAULT_TIMEOUT=120
# Path to the (nested) Isaac Lab checkout inside the Arena submodule.
ENV ISAACLAB_PATH=${WORKDIR}/submodules/IsaacLab-Arena/submodules/IsaacLab

Expand Down