Skip to content

Remove NGC login from CI/nightly and add isolated docker config - #66

Merged
peterd-NV merged 2 commits into
mainfrom
peterd/fix_ci_login
Aug 18, 2026
Merged

peterd-NV merged 2 commits into
mainfrom
peterd/fix_ci_login

Conversation

@peterd-NV

@peterd-NV peterd-NV commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

AutoData CI was previously using an NGC API key via github secret to login and pull the base image. This affected other jobs running on CI machines. The github secret was removed which now causes AutoData to be unable to pull the base image.

The base image in a publicly accessible Isaac Sim image that should not require any login. This PR removes the login from both CI and nightly. It also configures docker test to use an isolated config directory to ensure that docker doesn't read stale credentials from the runner.

Summary by CodeRabbit

  • Bug Fixes
    • Improved end-to-end test reliability by isolating Docker credentials during test runs.
    • Prevented shared runner authentication state from affecting access to public container images.
    • Increased resilience to temporary package-index issues with automatic retries and longer package installation timeouts.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 17aaa3d1-ca7a-41bd-b618-b294776bea5d

📥 Commits

Reviewing files that changed from the base of the PR and between 7803c2d and 78169dc.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • .github/workflows/nightly.yml
  • docker/Dockerfile.isaac_autodata

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The E2E workflows no longer perform NGC login. They use temporary Docker configuration directories. The Docker image sets global pip retry and timeout values.

Changes

CI runtime reliability

Layer / File(s) Summary
Temporary Docker configuration for E2E jobs
.github/workflows/ci.yml, .github/workflows/nightly.yml
The E2E jobs create temporary DOCKER_CONFIG directories and run tests without NGC credential validation or Docker login.
Container pip retry settings
docker/Dockerfile.isaac_autodata
The image sets PIP_RETRIES=10 and PIP_DEFAULT_TIMEOUT=120 for pip commands.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 78169

This change removes CI authentication and isolates Docker credentials for the affected workflows; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested reviewers: njawale42, hguillen

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main workflow and Docker configuration changes.
Description check ✅ Passed The description explains the reason, changes, and impact, although it does not use the template's Detailed description heading.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch peterd/fix_ci_login

Comment @coderabbitai help to get the list of available commands.

@peterd-NV peterd-NV changed the title test no ngc login Remove NGC login from CI/nightly and add isolated docker config Aug 18, 2026
@peterd-NV
peterd-NV marked this pull request as ready for review August 18, 2026 18:38
@peterd-NV
peterd-NV requested a review from njawale42 as a code owner August 18, 2026 18:38

@njawale42 njawale42 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterd-NV
peterd-NV merged commit eb66652 into main Aug 18, 2026
7 of 9 checks passed
peterd-NV added a commit that referenced this pull request Aug 20, 2026
* remove ngc login

* add pip retry

(cherry picked from commit eb66652)
peterd-NV added a commit that referenced this pull request Aug 20, 2026
…in from CI/nightly and add isolated docker config #66 (#69)

* chore: drop the broken docs/agents/INDEX.md requirement from AGENTS.md (#68)

The "Working on this codebase" section directed every task to first
read docs/agents/INDEX.md, but docs/agents/ has never existed in this
repo's history on any branch (git log --all --oneline -- docs/agents/
returns nothing). This gate blocked every task from being started per
AGENTS.md's own instructions, so remove the dead requirement.

(cherry picked from commit 60f23d9)

* Remove NGC login from CI/nightly and add isolated docker config (#66)

* remove ngc login

* add pip retry

(cherry picked from commit eb66652)

---------

Co-authored-by: Billy Okal <bokal@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants