Remove NGC login from CI/nightly and add isolated docker config - #66
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe E2E workflows no longer perform NGC login. They use temporary Docker configuration directories. The Docker image sets global pip retry and timeout values. ChangesCI runtime reliability
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes CI authentication and isolates Docker credentials for the affected workflows; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
* remove ngc login * add pip retry (cherry picked from commit eb66652)
…in from CI/nightly and add isolated docker config #66 (#69) * chore: drop the broken docs/agents/INDEX.md requirement from AGENTS.md (#68) The "Working on this codebase" section directed every task to first read docs/agents/INDEX.md, but docs/agents/ has never existed in this repo's history on any branch (git log --all --oneline -- docs/agents/ returns nothing). This gate blocked every task from being started per AGENTS.md's own instructions, so remove the dead requirement. (cherry picked from commit 60f23d9) * Remove NGC login from CI/nightly and add isolated docker config (#66) * remove ngc login * add pip retry (cherry picked from commit eb66652) --------- Co-authored-by: Billy Okal <bokal@nvidia.com>
Summary
AutoData CI was previously using an NGC API key via github secret to login and pull the base image. This affected other jobs running on CI machines. The github secret was removed which now causes AutoData to be unable to pull the base image.
The base image in a publicly accessible Isaac Sim image that should not require any login. This PR removes the login from both CI and nightly. It also configures docker test to use an isolated config directory to ensure that docker doesn't read stale credentials from the runner.
Summary by CodeRabbit