Repository navigation
⬆️ integrate upstream generator fixes - #2
Merged
Merged
Conversation
Introduce emission of a custom FractionDigitsAttribute for properties with XSD <xs:fractionDigits> restrictions. Add a --metadataNamespace option to control the namespace for generated metadata helpers (default: XmlSchemaClassGenerator.Metadata). Implement a MetadataHelperEmitter to ensure helpers are generated only when needed. Refactor restriction attribute emission to use a registry, and update tests to verify correct behavior and namespace usage.
Introduce MetadataEmissionMode option (None/Enabled) to control whether metadata helper types (e.g., custom attributes) are emitted in generated code. Update CLI to support --metadataEmissionMode, propagate the setting through Generator and GeneratorConfiguration, and ensure emitters respect the mode. Refactor and update tests to verify correct behavior for both enabled and disabled modes.
…gitsDataAnnotationInGeneratedModels Add support for custom FractionDigitsAttribute
Add regression test to ensure generated EnumValue uses the generic Enum.TryParse<T> method, compatible with .NET Framework 4.0 and .NET Standard 2.0. Update code generation logic to avoid .NET 5+ only overloads and return the enum result directly, improving cross-framework compatibility.
…rse-net48-compat Fix: use generic Enum.TryParse<> for EnumValue property (net48 / netstandard2.x compat)
…e correct setters
…value-as-name Reference backing fields called "value" using "this.value"
Expanded the list of valid types for the --integer option in the README.
--- updated-dependencies: - dependency-name: coverlet.msbuild dependency-version: 10.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
--- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-version: 5.3.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…lassGenerator.Tests/coverlet.msbuild-10.0.0 Bump coverlet.msbuild from 6.0.4 to 10.0.0
…lassGenerator.Tests/Microsoft.CodeAnalysis.CSharp-5.3.0 Bump Microsoft.CodeAnalysis.CSharp from 4.14.0 to 5.3.0
…tion-item-string-length Emit CollectionItemStringLengthAttribute for restricted string collections
--- updated-dependencies: - dependency-name: Microsoft.SourceLink.GitHub dependency-version: 10.0.400 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.SourceLink.GitHub dependency-version: 10.0.400 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.SourceLink.GitHub dependency-version: 10.0.400 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.SourceLink.GitHub dependency-version: 10.0.400 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
--- updated-dependencies: - dependency-name: System.CodeDom dependency-version: 10.0.11 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…enerator/multi-2fd80f2cb3 Bump Microsoft.SourceLink.GitHub from 10.0.301 to 10.0.400
…lassGenerator.Tests/System.CodeDom-10.0.11 Bump System.CodeDom from 10.0.10 to 10.0.11
--- updated-dependencies: - dependency-name: System.Collections.Immutable dependency-version: 10.0.11 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…lassGenerator/System.Collections.Immutable-10.0.11 Bump System.Collections.Immutable from 10.0.10 to 10.0.11
--- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.9.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
--- updated-dependencies: - dependency-name: xunit.runner.visualstudio dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…lassGenerator.Tests/Microsoft.NET.Test.Sdk-18.9.0 Bump Microsoft.NET.Test.Sdk from 18.8.1 to 18.9.0
…lassGenerator.Tests/xunit.runner.visualstudio-4.0.0 Bump xunit.runner.visualstudio from 3.1.5 to 4.0.0
--- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.CSharp dependency-version: 5.9.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…lassGenerator.Tests/Microsoft.CodeAnalysis.CSharp-5.9.0 Bump Microsoft.CodeAnalysis.CSharp from 5.6.0 to 5.9.0
--- updated-dependencies: - dependency-name: Microsoft.SourceLink.GitHub dependency-version: 10.0.401 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.SourceLink.GitHub dependency-version: 10.0.401 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.SourceLink.GitHub dependency-version: 10.0.401 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.SourceLink.GitHub dependency-version: 10.0.401 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
--- updated-dependencies: - dependency-name: System.CodeDom dependency-version: 10.0.12 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…enerator/multi-f33e791ab4 Bump Microsoft.SourceLink.GitHub from 10.0.400 to 10.0.401
…lassGenerator.Tests/System.CodeDom-10.0.12 Bump System.CodeDom from 10.0.11 to 10.0.12
--- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.10.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…lassGenerator.Tests/Microsoft.NET.Test.Sdk-18.10.1 Bump Microsoft.NET.Test.Sdk from 18.10.0 to 18.10.1
--- updated-dependencies: - dependency-name: coverlet.msbuild dependency-version: 10.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…lassGenerator.Tests/coverlet.msbuild-10.1.0 Bump coverlet.msbuild from 10.0.1 to 10.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate upstream
mganss/XmlSchemaClassGeneratorthrougha75f225, including the NeTEx substitution fixes. Some generated properties disappear because they mapped abstract elements, unrelated substitutes, or duplicate XML names.Changes
Resolved the conflicts while retaining the fork's choice analyzer, fixed-value APIs, token-list collections, and scalar default presence tracking. Fixed upstream traversal through abstract substitution members so concrete descendants remain available, and preserved object defaults when scalar tracking is enabled.
Added
UseLegacyMixedTextPropertyNameso Transmodel can retain its existingTextproperties. Corrected strict decimal bounds becausefractionDigitslimits scale rather than reducing the magnitude allowed bytotalDigits.Includes upstream dependency updates, schema fixtures, anonymous enum lists, and opt-in metadata attributes. The generated API removals need a separate breaking Transmodel release.
Transmodel package integration: Transmodel #74.
Validation
All
767generator tests and41analyzer tests pass. New regressions failed before the fixes. Regenerated all11Transmodel schema projects with a candidate package, built with zero warnings or errors, and passed all191consumer tests.This PR was generated with
gpt-6-astrain Codex via T3 Code.