Skip to content

[tests] AOT compilation failure fixes #14553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sayakpaul merged 2 commits into from
Aug 22, 2026
+5 −2
Merged

[tests] AOT compilation failure fixes #14553

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe244e3
compilation failure fixes
sayakpaul Aug 21, 2026
518b9c0
Merge branch 'main' into compilation-failures-fix
sayakpaul Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions docker/diffusers-pytorch-cuda/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,14 @@ RUN apt-get -y update \
&& add-apt-repository ppa:deadsnakes/ppa && \
apt-get update

# cuda-cudart-dev provides the CUDA headers (cuda.h etc.) AOT-inductor compilation needs;
# the runtime base image only ships the libraries.
# The runtime base image only ships the CUDA libraries, but AOT-inductor compiles a C++
# wrapper against the CUDA headers. cuda-cudart-dev provides cuda.h/cuda_runtime_api.h, and
# cuda-nvcc pulls in the crt/ headers (crt/host_defines.h etc.) that cuda_runtime_api.h
# includes in turn -- both are needed or the AOT tests fail with a CppCompileError.
RUN apt install -y bash \
build-essential \
cuda-cudart-dev-12-9 \
cuda-nvcc-12-9 \

@dg845 dg845 Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked Claude to review the comment and it says that cuda-crt-12-9 would suffice if we only need the crt/* headers, since that's where those headers actually live, and this would be better because cuda-crt-12-9 is much smaller than cuda-nvcc-12-9.

I'm not familiar enough with AOT to confirm this claim, but it seems like it could be worth testing out.

@sayakpaul sayakpaul Aug 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think it’s worth repeating the entire testing process just because of a smaller binary because I don’t think we gain much from that (it’s already in a Docker container so we don’t save much on setup anyway).

git \
git-lfs \
curl \
Expand Down
Loading