[tests] AOT compilation failure fixes - #14553
Conversation
|
/diffusers-bot pytest -k "test_compile_works_with_aot" tests/models/ |
|
✅ |
| RUN apt install -y bash \ | ||
| build-essential \ | ||
| cuda-cudart-dev-12-9 \ | ||
| cuda-nvcc-12-9 \ |
There was a problem hiding this comment.
I asked Claude to review the comment and it says that cuda-crt-12-9 would suffice if we only need the crt/* headers, since that's where those headers actually live, and this would be better because cuda-crt-12-9 is much smaller than cuda-nvcc-12-9.
I'm not familiar enough with AOT to confirm this claim, but it seems like it could be worth testing out.
There was a problem hiding this comment.
I don’t think it’s worth repeating the entire testing process just because of a smaller binary because I don’t think we gain much from that (it’s already in a Docker container so we don’t save much on setup anyway).
dg845
left a comment
dg845
left a comment
There was a problem hiding this comment.
Thanks! Left one comment.
2 participants
#14464 fixed only a part of the AOT compilation failure problems. They are still happening see: https://github.com/huggingface/diffusers/actions/runs/32379919032.
This PR fully fixes it.