deps: bump radiance to f59e3fe (Share My Connection peer core) - #8987
Conversation
radiance#589 merged the peer-core stack into radiance main, so main can now pin a main commit instead of trailing it. This also brings in #600, which is what makes the server-side per-peer client cap real: the peer reports the number of distinct clients it is carrying on each heartbeat, and without that report lantern-cloud only ever sees the provisional counter it maintains itself, so the cap bounds assignment rate rather than concurrency. The peer code ships dormant. applyPeerShare only runs when the peer_share toggle appears in a settings diff and the setting reads false until the user opts in, so nothing here turns a client into a peer. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe direct ChangesRadiance dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized dependency-pin update with no actionable merge-blocking risk remaining after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the pinned github.com/getlantern/radiance dependency to a newer commit on radiance/main, enabling the peer-core stack (including client-side active_clients reporting) to ship from lantern main.
Changes:
- Bump
github.com/getlantern/radiancefromv0.0.0-20260814190822-5559a4073bf3tov0.0.0-20260814212003-f59e3fe0a53b. - Update
go.sumchecksums accordingly (no other module entries changed in the reviewed hunk).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates the required github.com/getlantern/radiance pseudo-version to the new main commit. |
| go.sum | Replaces the old radiance checksums with the new version’s checksums. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Moves lantern main's radiance pin onto a main commit for the first time since the Share My Connection work started.
5559a407→f59e3fe(v0.0.0-20260814212003-f59e3fe0a53b)Why now
radiance#589 merged the peer-core stack into radiance main, so there's no longer a feature branch to trail.
The consequential part is what rides along: radiance#600, the client-side load report. The server-side per-peer client cap (lantern-cloud#3157, #3174) is already deployed, but it reads
active_clientsfrom the peer's heartbeat — and no released client sends it. Until this pin ships, lantern-cloud only ever sees the provisional counter it maintains itself, which is reset on every heartbeat. That bounds assignment rate (~N per 150s) rather than concurrency. This is the half that makes the cap mean what it says.Risk
Low, and the peer code ships dormant:
applyPeerShareonly runs whenpeer_share_enabledappears in a settings diff, and the setting reads false until the user opts in. Nothing here turns a client into a peer.Verification
go mod tidyproduced zero transitive churn — only the two radiance lines ingo.modand their four ingo.sumgo build -tags with_gvisor,with_quic,with_wireguard,with_utls,with_grpc,with_conntrack ./...→ exit 0peer,unbounded,portforward,events,ipc,settings) — all green; re-ran against the real merge commit on radiance main, also greenSummary by CodeRabbit