Skip to content

deps: bump radiance for the iOS peer-share gate - #8988

Merged
myleshorton merged 1 commit into
mainfrom
fisk/bump-radiance-ios-gate
Aug 16, 2026
Merged

deps: bump radiance for the iOS peer-share gate#8988
myleshorton merged 1 commit into
mainfrom
fisk/bump-radiance-ios-gate

Conversation

@myleshorton

@myleshorton myleshorton commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

f59e3fee0df3f4 (v0.0.0-20260816070116-e0df3f4b8c1d)

Picks up radiance#605, which makes the backend refuse to serve as a peer on iOS.

Why it matters now

#8819 landed the SmC screen on main along with the UI-side gate, so an iOS user cannot select the peer-proxy mode. But until this bump, that was the only layer — main's pinned radiance had no backend gate at all.

The UI gate covers the case where the UI is the one asking. It does not cover resumePeerShareIfEnabled, which reads the persisted peer_share_enabled at launch and calls applyPeerShare directly. A setting persisted before the platform was excluded, or arriving from another device, would take that path on every launch with nothing to stop it. This bump closes that.

It also clears the stale setting on the way through, so the state self-heals on first launch rather than retrying forever.

Verification

  • go mod tidy in the same commit; only the radiance lines moved in go.mod/go.sum, no transitive churn
  • go build with lantern's tags → exit 0
  • Full ./lantern-core/... suite green

Summary by CodeRabbit

  • Chores
    • Updated an internal dependency to a newer version for improved compatibility and maintenance.

radiance#605 makes the backend refuse to serve as a peer on iOS, where it runs
inside the network extension on a memory budget that cannot carry the peer
proxy's second sing-box instance.

main already has the UI half of this from #8819, which keeps the mode
unreachable on iOS. This is the half that holds when the UI is not the one
asking — a setting persisted before the platform was excluded, or arriving
from another device, reaches applyPeerShare directly through the auto-resume
path on every launch.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 16, 2026 07:02
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4baee3e5-fa52-4d0d-83fe-8eb2716f4faa

📥 Commits

Reviewing files that changed from the base of the PR and between ad6fcc4 and d1e9944.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Included review availability: Your plan includes up to 10 reviews per rolling hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The PR updates the direct github.com/getlantern/radiance dependency in go.mod to a newer pseudo-version.

Changes

Radiance dependency update

Layer / File(s) Summary
Update Radiance dependency
go.mod
The Radiance dependency changes from v0.0.0-20260814212003-f59e3fe0a53b to v0.0.0-20260816070116-e0df3f4b8c1d.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to d1e99

This dependency update adds the iOS peer-share backend safeguard without broader dependency churn, and no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

Suggested reviewers: garmr-ulfr, jigar-f

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the Radiance dependency update and its purpose: enabling the iOS peer-share gate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fisk/bump-radiance-ios-gate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pinned github.com/getlantern/radiance dependency to pick up upstream changes that add a backend-side iOS peer-share gate (and clear stale persisted peer-share state), closing a gap where iOS could still enter peer-share via persisted settings on launch.

Changes:

  • Bump github.com/getlantern/radiance from v0.0.0-20260814212003-f59e3fe0a53b to v0.0.0-20260816070116-e0df3f4b8c1d.
  • Update go.sum entries accordingly (no additional module churn reflected in the diff).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go.mod Pins radiance to the newer pseudo-version containing the iOS peer-share backend gate.
go.sum Updates radiance checksums to match the new version.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@myleshorton
myleshorton merged commit b5ed62d into main Aug 16, 2026
11 checks passed
@myleshorton
myleshorton deleted the fisk/bump-radiance-ios-gate branch August 16, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants