Skip to content

Avoid the extra JavaScript copy in WebGPU buffer uploads #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JulianRuiseco wants to merge 1 commit into
base: patch-27.0.1
Choose a base branch
from
Draft

Avoid the extra JavaScript copy in WebGPU buffer uploads #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions wgpu/src/backend/webgpu.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2512,20 +2512,13 @@ impl dispatch::QueueInterface for WebQueue {
data: &[u8],
) {
let buffer = buffer.as_webgpu();
/* Skip the copy once gecko allows BufferSource instead of ArrayBuffer
self.inner.write_buffer_with_f64_and_u8_array_and_f64_and_f64(
&buffer.buffer,
offset as f64,
data,
0f64,
data.len() as f64,
);
*/
// writeBuffer snapshots the source synchronously. The slice binding passes a
// view of WASM memory, so no intermediate JavaScript allocation is needed.
self.inner
.write_buffer_with_f64_and_buffer_source_and_f64_and_f64(
.write_buffer_with_f64_and_u8_slice_and_f64_and_f64(
&buffer.inner,
offset as f64,
&js_sys::Uint8Array::from(data).buffer(),
data,
0f64,
data.len() as f64,
)
Expand Down
Loading