Repository navigation
Avoid the extra JavaScript copy in WebGPU buffer uploads - #5
Draft
JulianRuiseco wants to merge 1 commit into
Draft
JulianRuiseco wants to merge 1 commit into
JulianRuiseco wants to merge 1 commit into
Conversation
fslabs-bot
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
fslabs-bot
Bot
added
the
size/S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebGPU uploads currently allocate and copy each Rust slice into a new JavaScript Uint8Array. Pass the borrowed WASM slice to writeBuffer instead. WebGPU snapshots its source synchronously, so the slice need not outlive the call.
Validation: Linux Bazel built the SpatialEngine WASM consumer with this patch. On an M4 Max, repeated OS1-128 replay overload runs completed 448-469 MiB/s versus 426-431 MiB/s before the change. Both changed runs had an 18.0 ms p95 browser animation-frame interval. GPU readback matched all 32 sampled writes (425,824 bytes). Warm 8x replay remained near 388 MiB/s in both variants.
This removes one JavaScript allocation and copy per write; browser-internal copies remain. Chromium WebGPU was tested. Safari and Firefox runtime checks remain open. Browser animation-frame timing does not prove complete visible frames.