[VFIO] Chapter 2, Section 2: Caps and Bars - #6085
Merged
ShadowCurse merged 3 commits intoAug 18, 2026
Merged
Conversation
ShadowCurse
added
Status: Awaiting review
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/vfio #6085 +/- ##
================================================
+ Coverage 82.78% 82.86% +0.07%
================================================
Files 279 280 +1
Lines 30871 31115 +244
================================================
+ Hits 25558 25782 +224
- Misses 5313 5333 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
vfio_part_2_2
branch
2 times, most recently
from
August 7, 2026 10:56
51f2279 to
04e6c17
Compare
Add dependencies for the vfio implementation Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
vfio_part_2_2
branch
2 times, most recently
from
August 7, 2026 12:46
d79eb85 to
b940f85
Compare
ilstam
reviewed
Aug 7, 2026
Manciukic
reviewed
Aug 10, 2026
Manciukic
left a comment
Manciukic
left a comment
Contributor
There was a problem hiding this comment.
functionally LGTM, but it's still very hard go grok. The structs are an improvement over the previous design, but it'd prefer to use impl blocks to logically group and confine the operations on the different structs you introduced, following a more OOD pattern.
ShadowCurse
force-pushed
the
vfio_part_2_2
branch
9 times, most recently
from
August 13, 2026 14:00
ce8ff52 to
921a9d3
Compare
Manciukic
previously approved these changes
Aug 17, 2026
ilstam
reviewed
Aug 17, 2026
ilstam
reviewed
Aug 17, 2026
ShadowCurse
force-pushed
the
vfio_part_2_2
branch
from
August 17, 2026 13:12
921a9d3 to
6f8461d
Compare
ilstam
reviewed
Aug 17, 2026
ShadowCurse
force-pushed
the
vfio_part_2_2
branch
3 times, most recently
from
August 18, 2026 10:54
400c457 to
e6f6a96
Compare
Scan device config space in search of it's capabilities and extended capabilities. Only interesting legacy capabilities are: Msix and PciExpress. Out of all extended capabilities search for ARI, ReBAR and SR-IOV caps and mask them out since we either don't support those features or they contain host information we don't want to provide to the guest. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
vfio_part_2_2
branch
from
August 18, 2026 10:55
e6f6a96 to
1e6dd6a
Compare
Gather information about BARs the device has and allocate space for them in the guest memory. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
vfio_part_2_2
branch
from
August 18, 2026 11:05
1e6dd6a to
b6c6107
Compare
ilstam
approved these changes
Aug 18, 2026
Manciukic
approved these changes
Aug 18, 2026
ShadowCurse
enabled auto-merge (rebase)
August 18, 2026 16:18
ShadowCurse
merged commit Aug 18, 2026
8c8fc63
into
firecracker-microvm:feature/vfio
6 of 7 checks passed
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
First 3 commits from the #6055 PR. Add functions and types to handle parsing device PCI caps and BARs information. None of these are used yet.
Part of #5679
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.