[VFIO] Chapter 2, Section 4: VfioDevice and its traits - #6183
Draft
ShadowCurse wants to merge 3 commits into
Draft
[VFIO] Chapter 2, Section 4: VfioDevice and its traits#6183ShadowCurse wants to merge 3 commits into
VfioDevice and its traits#6183ShadowCurse wants to merge 3 commits into
Conversation
Combine all previous steps to create a VfioDevice type. One minor change is the removal of VfioBarMappings wrapper. Instead just store the vector of VfioBarMapping directly inside VfioDevice and unmap them in VfioDevice::drop. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Implement emulation for the BAR accesses of the VfioDevice. The emulation only needs to happen for Msix table/pba, but since they may be smaller than host page region, the code has to handle full host page sized regions. If access does not hit any Msix table/pba, it is forwarded to the device directly. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Implement emulatino logic for the guest accesses to the configuration space of the device. Emulation only touches some registers like BARs, Msix, masked registers. Everything else is forwarded to the device. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/vfio #6183 +/- ##
================================================
- Coverage 82.77% 82.34% -0.44%
================================================
Files 280 280
Lines 31413 32114 +701
================================================
+ Hits 26002 26443 +441
- Misses 5411 5671 +260
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Another set of commits taken from #6055 PR. Here we add finally add
VfioDeviceand implementBusDeviceandPciDevicetraits for itLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.