feat(spec-tests): validate transaction test fixtures against EELS - #3494
Open
danceratopz wants to merge 2 commits into
Open
feat(spec-tests): validate transaction test fixtures against EELS#3494danceratopz wants to merge 2 commits into
danceratopz wants to merge 2 commits into
Conversation
This was referenced Sep 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## experiments/resolve-implicit-tx-test-gas-limits #3494 +/- ##
===================================================================================
+ Coverage 93.90% 94.01% +0.10%
===================================================================================
Files 624 624
Lines 36938 36938
Branches 3330 3330
===================================================================================
+ Hits 34688 34728 +40
+ Misses 1569 1534 -35
+ Partials 681 676 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danceratopz
force-pushed
the
experiments/run-tx-tests-against-eels
branch
from
September 1, 2026 16:36
ccb2700 to
0be0446
Compare
danceratopz
force-pushed
the
experiments/run-tx-tests-against-eels
branch
from
September 1, 2026 16:45
0be0446 to
479d68b
Compare
danceratopz
marked this pull request as draft
September 1, 2026 16:48
danceratopz
force-pushed
the
experiments/run-tx-tests-against-eels
branch
2 times, most recently
from
September 1, 2026 19:05
8dcab7a to
3e80348
Compare
danceratopz
force-pushed
the
experiments/run-tx-tests-against-eels
branch
from
September 1, 2026 19:37
3e80348 to
0a64bab
Compare
danceratopz
marked this pull request as ready for review
September 1, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Transaction test fixtures were generated but not exercised by the repository's JSON loader. That left their raw transaction bytes and expected results unchecked against EELS.
This PR adds a fork-aware adapter that decodes each raw transaction and uses EELS to validate its chain ID, signature, and state-independent transaction rules. It compares the resulting exception, transaction hash, sender, and intrinsic gas with the fixture. The JSON loader now discovers transaction fixtures from both checked-in files and filler output.
The adapter uses the common
validate_transaction(transaction)interface introduced by the first PR in this stack. It does not duplicate fork validation rules.Stack
This is the final PR in a three-PR stack:
Related Issues or PRs
Follows #3156, which added the transaction tests and fixtures this loader validates.
Testing
just staticat each commit boundary.just test-testsat each commit boundary.Checklist
just static<type>(<area>): <title>, where<type>and<area>match the applied labels.Cute Animal Picture