feat(test-fixtures): resolve implicit transaction test gas limits - #3493
Open
danceratopz wants to merge 2 commits into
Open
Conversation
This was referenced Sep 1, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## experiments/expose-state-independent-tx-validation #3493 +/- ##
===================================================================================
Coverage 93.90% 93.90%
===================================================================================
Files 624 624
Lines 36938 36938
Branches 3330 3330
===================================================================================
Hits 34688 34688
Misses 1569 1569
Partials 681 681
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
danceratopz
force-pushed
the
experiments/resolve-implicit-tx-test-gas-limits
branch
from
September 1, 2026 16:34
43fdc7b to
c556791
Compare
danceratopz
force-pushed
the
experiments/resolve-implicit-tx-test-gas-limits
branch
from
September 1, 2026 16:45
c556791 to
d93b047
Compare
danceratopz
marked this pull request as draft
September 1, 2026 16:48
danceratopz
force-pushed
the
experiments/resolve-implicit-tx-test-gas-limits
branch
from
September 1, 2026 19:37
d346035 to
73023cf
Compare
danceratopz
marked this pull request as ready for review
September 1, 2026 19:37
gurukamath
self-requested a review
September 2, 2026 06:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
StateTestandBlockchainTestresolve an omitted transaction gas limit before signing, butTransactionTestpreviously signed the transaction directly. This forced transaction tests to provide an otherwise arbitrary gas limit or fail withgas_limit must be set to sign a transaction.This PR resolves omitted limits through the shared
Transaction.with_gas_limit(...)behavior before signing. It uses the configured default block gas budget, preserves explicit limits, applies Osaka's transaction gas cap, and retains Amsterdam's state gas reservoir behavior.The existing transaction tests now omit gas limits when gas is unrelated to the behavior under test. This keeps them useful as examples of the intended
TransactionTestAPI. The explicit limit in the raw RLP source helper remains because that helper signs and serializes its transaction before the filler or execute pipeline can resolve an implicit limit.The test intentions and expected results remain unchanged. The refactored tests still exercise the same nonce overflow, authorization-format, and RLP-validation cases with the same expected exceptions. Their serialized bytes and signatures intentionally change because the framework now supplies the gas limit.
Execute mode remains supported.
TransactionPost.prepare_transactions()resolves omitted limits from the live environment and fork configuration before calculating balances and signing transactions.Stack
This is the second PR in a three-PR stack:
Related Issues or PRs
Fixes #3489.
Testing
hasher compare: 124 transaction fixture hashes changed because the gas limit and signature changed; none of the 1,178 expectedresultvalues or exceptions changed.just staticjust test-testsjust json-loaderon the restacked feat(spec-tests): validate transaction test fixtures against EELS #3494 branchChecklist
just static<type>(<area>): <title>, where<type>and<area>match the applied labels.Cute Animal Picture