Skip to content

Use mocks for unsupported platform test#2765

Merged
paul-nechifor merged 3 commits into
mainfrom
sam/fix-rejects-unsupported-platform
Jul 8, 2026
Merged

Use mocks for unsupported platform test#2765
paul-nechifor merged 3 commits into
mainfrom
sam/fix-rejects-unsupported-platform

Conversation

@Dreamsorcerer

Copy link
Copy Markdown
Collaborator

This allows the test to actually run in CI.

@greptile-apps

greptile-apps Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR makes the Unity unsupported-platform test run consistently in CI.

  • Adds a module import so the test can patch the platform helpers used by Unity validation.
  • Replaces the host-dependent skip with parametrized mocked platform cases.
  • Covers both non-Linux and non-x86_64 rejection inputs.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
dimos/simulation/unity/test_unity_sim.py Updates the unsupported-platform test to use mocked platform values instead of relying on the CI host platform.

Reviews (2): Last reviewed commit: "Update test_unity_sim.py" | Re-trigger Greptile

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #2765      +/-   ##
==========================================
- Coverage   72.22%   72.14%   -0.09%     
==========================================
  Files         936      936              
  Lines       83188    83191       +3     
  Branches     7544     7544              
==========================================
- Hits        60083    60014      -69     
- Misses      21112    21172      +60     
- Partials     1993     2005      +12     
Flag Coverage Δ
OS-ubuntu-24.04-arm 64.43% <100.00%> (-0.01%) ⬇️
OS-ubuntu-latest 67.04% <100.00%> (+0.01%) ⬆️
Py-3.10 67.02% <100.00%> (+<0.01%) ⬆️
Py-3.11 67.02% <100.00%> (+0.01%) ⬆️
Py-3.12 67.02% <100.00%> (+<0.01%) ⬆️
Py-3.13 67.03% <100.00%> (+0.01%) ⬆️
Py-3.14 67.03% <100.00%> (-0.01%) ⬇️
Py-3.14t 67.02% <100.00%> (+0.01%) ⬆️
SelfHosted-Large 30.24% <60.00%> (+0.01%) ⬆️
SelfHosted-Linux 38.11% <60.00%> (+0.06%) ⬆️
SelfHosted-macOS 36.44% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/simulation/unity/test_unity_sim.py 95.22% <100.00%> (+0.05%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@paul-nechifor paul-nechifor enabled auto-merge (squash) July 8, 2026 01:47
@leshy

leshy commented Jul 8, 2026

Copy link
Copy Markdown
Member

I think we are actually deleting this sim?

@paul-nechifor paul-nechifor merged commit 55600ac into main Jul 8, 2026
82 of 89 checks passed
@paul-nechifor paul-nechifor deleted the sam/fix-rejects-unsupported-platform branch July 8, 2026 17:50
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Jul 8, 2026
@Dreamsorcerer

Copy link
Copy Markdown
Collaborator Author

I think we are actually deleting this sim?

Regardless, it's a small adjustment. If it gets deleted soon, nothing lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants