Skip to content

fix(ProposalGC): ABSORBED requires the whole entry in the body, not a 60-char prefix (#2185) #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bowlerjim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ProposalGC): ABSORBED requires the whole entry in the body, not a 60-char prefix (#2185) #2197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions LifeOS/install/LIFEOS/TOOLS/ProposalGC.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,16 @@ function appliedTs(entry: string): string {
return m ? m[1].trim() : "";
}

/** Substantive core of an entry (first ~60 normalized chars) for absorption test. */
function core(entry: string): string {
return normalize(entry).slice(0, 60);
/**
* Absorption test: the ENTIRE normalized entry must already appear in the
* canonical body. A prefix match is not proof of absorption — the reviewer
* routinely restates an existing rule in order to extend it, and a prefix
* test reads that restatement as redundancy and deletes the extension with
* it. The 30-char floor keeps a one-word fragment from matching anything.
*/
function absorbed(entry: string, bodyNorm: string): boolean {
const norm = normalize(entry);
return norm.length >= 30 && bodyNorm.includes(norm);
}

function gcFile(relPath: string): { removals: Removal[]; nextContent: string | null } {
Expand Down Expand Up @@ -115,7 +122,7 @@ function gcFile(relPath: string): { removals: Removal[]; nextContent: string | n
if (/\[SUPERSEDED/i.test(e.text)) {
removals.push({ file: relPath, reason: "superseded", text: e.text.trim() });
removeIdx.add(e.i);
} else if (core(e.text).length >= 30 && bodyNorm.includes(core(e.text))) {
} else if (absorbed(e.text, bodyNorm)) {
removals.push({ file: relPath, reason: "absorbed", text: e.text.trim() });
removeIdx.add(e.i);
}
Expand Down