Conversation
… 60-char prefix (danielmiessler#2185) The header states the invariant: "only three removal classes, each PROVABLE ... it cannot drop a live directive", with ABSORBED defined as "the entry's substantive text already appears verbatim in the file's canonical body". The code tested `normalize(entry).slice(0, 60)` — any proposal whose first 60 characters appear in the body was deleted whole. The colliding case is the ordinary one: the reviewer restates an existing rule in order to extend it. The restatement matches the body, and the extension is destroyed with it. This is not human-gated: `--auto`, the documented scheduled entry point, implies `--apply`. Require the entire normalized entry, keeping the 30-character floor. Verified on a fixture whose body holds a backup rule and whose proposals section holds (a) that rule restated with an added offsite-copy clause and (b) an exact restatement. Before: both classified `absorbed`, and `--apply` emptied the section. After: only the exact restatement is removed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PuS77R8a6Lhp7jK6dnwdTh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2185.
The header states the invariant: "only three removal classes, each PROVABLE ... it cannot drop a live directive", with ABSORBED defined as "the entry's substantive text already appears verbatim in the file's canonical body". The code tested
normalize(entry).slice(0, 60), so any proposal whose first 60 characters appeared in the body was deleted whole.The colliding case is the ordinary one: the reviewer restates an existing rule in order to extend it. The restatement matches the body, and the extension is destroyed with it. This is not human-gated, since
--auto(the documented scheduled entry point) implies--apply.This requires the entire normalized entry, keeping the 30-character floor.
Verified on a fixture whose body holds a backup rule and whose proposals section holds (a) that rule restated with an added offsite-copy clause and (b) an exact restatement. Before: both classified
absorbed, and--applyemptied the section. After: only the exact restatement is removed.🤖 Generated with Claude Code
https://claude.ai/code/session_01PuS77R8a6Lhp7jK6dnwdTh