Repository navigation
fix(auth): support renewable credential profiles - #9
Merged
Merged
Conversation
AndresRCB
marked this pull request as ready for review
October 9, 2026 10:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit AWS profiles use the SDK credential-provider chain and refresh credential-process credentials during a running command. Missing or empty explicit profiles fail without implicit host-credential fallback. Process execution has bounded output and time, stops helper descendants on timeout, and keeps helper input and diagnostic output separate from command data and logs.
Moves credential safeguards into repository-owned code and removes vendoring. Builds use verified Go modules with AWS SDK v1.55.5, including HTTPS container credential endpoint support. Trace logging reports request metadata without signed HTTP headers. Storage endpoints and TLS options remain separate from credential exchanges.
Adds synthetic unit and CLI regressions for profile precedence, parser parity, role chains, renewal, timeout cleanup, stdin isolation, and credential-safe logs. Ignores local
.envfiles in Git and Docker build contexts. CI validates pull requests intocoreweavewith pinned actions and read-only permissions; merging does not automatically publish a release.Validation: native binary storage round-trip and in-process credential renewal against local MinIO, full race-enabled suite with local MinIO, repository QA checks, Go module verification, credential and CLI regressions on Go 1.20 and 1.22, Windows compilation, and changed-workflow validation.