Repository navigation
deps: bump aws-sdk-go to v1.55.5 (allow HTTPS container credential endpoints for CAIOS) - #8
Closed
wimarkuske wants to merge 1 commit into
Closed
wimarkuske wants to merge 1 commit into
wimarkuske wants to merge 1 commit into
Conversation
…endpoints s5cmd fails to authenticate against CoreWeave CAIOS when credentials are sourced from AWS_CONTAINER_CREDENTIALS_FULL_URI=https://api.coreweave.com/... The pinned aws-sdk-go v1.44.298 applies the loopback-only host check to the credential endpoint regardless of scheme, so any non-loopback host is rejected: HTTP credential provider invalid endpoint host, "api.coreweave.com", only loopback hosts are allowed. NoCredentialProviders: no valid providers in chain. aws-sdk-go relaxed this in later releases: the host restriction now only applies to plain-http endpoints (aws/defaults/defaults.go now gates the isAllowedHost check on parsed.Scheme == "http"), while https endpoints are permitted. Bumping to v1.55.5 (the last aws-sdk-go v1 release) picks up that change plus AWS_CONTAINER_AUTHORIZATION_TOKEN[_FILE] support. Verified: with v1.55.5 an https FULL_URI is no longer rejected with the loopback error, while an http FULL_URI to the same host still is. Mirrors unmerged upstream PR peak#769. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
wimarkuske
force-pushed
the
fix/caios-https-cred-endpoint-sdk-bump
branch
from
July 22, 2026 23:11
f3f5fa0 to
7316fee
Compare
Collaborator
|
Superseded by #9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
s5cmd cannot authenticate against CoreWeave CAIOS when credentials are sourced via the container credentials provider pointing at an HTTPS endpoint. A job configured with
AWS_CONTAINER_CREDENTIALS_FULL_URI=https://api.coreweave.com/...fails at startup:Root cause
The fork is pinned to
aws-sdk-go v1.44.298. In that version,aws/defaults/defaults.golocalHTTPCredProviderapplies the loopback-only host check to the credential endpoint regardless of URL scheme, so any non-loopback host — including a legitimate HTTPS token endpoint — is rejected and the whole provider chain collapses toNoCredentialProviders.Later aws-sdk-go releases relaxed this: the host restriction (
isAllowedHost, now loopback or ECS/EKS container IPs) is gated onparsed.Scheme == "http". HTTPS endpoints bypass the host allow-list, andAWS_CONTAINER_AUTHORIZATION_TOKEN[_FILE]support was added.Change
github.com/aws/aws-sdk-gov1.44.298→v1.55.5(last aws-sdk-go v1 release),go mod tidy+go mod vendor.Verification
Built with
go build -mod=vendor ./...(clean). Exerciseddefaults.RemoteCredProviderwithAWS_CONTAINER_CREDENTIALS_FULL_URIset:https://api.coreweave.com/tokenonly loopback hosts are allowedhttp://api.coreweave.com/tokenonly loopback/ecs/eks hosts are allowedSo the CAIOS HTTPS case is fixed while the plain-HTTP host restriction is preserved.
🤖 Generated with Claude Code
Release impact
Targets the
coreweavebranch. On merge,ci.ymlpush_dirty_tagcuts a newv2.3.0-<sha>tag, which triggersgoreleaser.yml(binaries +.debGitHub Release) anddocker.yml(ghcr.io/coreweave/s5cmd:<tag>+:latest). Re-pull that image/deb in the CAIOS transfer job to pick up the fix.