i18n: add Korean (ko) UI localization — full catalog, glossary-checked - #643
Open
riyenas0925 wants to merge 1 commit into
Open
i18n: add Korean (ko) UI localization — full catalog, glossary-checked#643riyenas0925 wants to merge 1 commit into
riyenas0925 wants to merge 1 commit into
Conversation
riyenas0925
force-pushed
the
i18n-korean
branch
3 times, most recently
from
September 6, 2026 01:20
2429f48 to
bb7f525
Compare
Add Korean as a selectable UI language. All 696 msgids in the current
catalog are translated (device UI, web UI, SQM/Bortle descriptions).
Astronomical nouns follow the Korean Astronomical Society glossary;
operational jargon follows common Korean amateur-astronomy usage
(plate solving -> 솔빙, align -> 얼라인, eyepiece -> 아이피스, ...).
EQ / Alt/Az / RA/Dec / GPS are kept verbatim per the i18n conventions.
Code: accept "ko" in the --lang validation list and the Flask
accept_languages list, add the Korean menu entry, reuse the Sarasa
CJK font for ko as for zh, and restart after switching to ko since
the font set changes. docs: add Korean to the Language values.
Every ko entry carries the AI-TRANSLATED review marker; "Appeal" is
additionally fuzzy. The other four catalogs only gain the two new
msgids ("Korean", "Language: ko").
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WErqKyPNdq326xqryfMJLX
riyenas0925
force-pushed
the
i18n-korean
branch
from
September 6, 2026 01:23
bb7f525 to
428b2de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Korean as a selectable UI language. All 696 msgids in the current
maincatalog are translated (device UI, web UI, SQM/Bortle descriptions), terminology was checked against the Korean Astronomical Society glossary and against everyday Korean amateur-astronomy usage, and the result was verified on a headless PiFinder run.Background
#500 started Korean support earlier this year but has not been merged, and the string set has moved on since then. Rather than rebase that draft, this PR builds a fresh catalog against today's
main. The code side lands on the same approach as #500 (reuse the Sarasa CJK font, restart on language switch,--lang ko, menu entry), so there is no design disagreement — thanks to @hjoungjoo for the groundwork. Happy to coordinate if merging into #500 is preferred.Translations — 696 entries, 0 untranslated
EPOCH,Knot,N/Astay in English because no Korean term is in common use.EQ,Alt/Az,RA/DecandGPSare kept verbatim per the i18n conventions.# AI-TRANSLATED (claude): needs human reviewmarker so reviewers can find and clear them. One low-confidence entry (Appeal→ 매력도) is also marked#, fuzzyand falls back to English until reviewed.Korean,Language: ko).Code changes
main.py,server.py: acceptkoin the--langvalidation list and the Flaskaccept_languageslist.ui/menu_structure.py:Koreanentry in Settings → Language, plus theLanguage: komarker string.ui/fonts.py:zhandkoboth usesarasa-mono-sc-light-nerd-font+patched.ttf(verified via fontTools that it carries the full Hangul range).ui/callbacks.py: restart after switching toko, same aszh, since the font set changes.docs/source/menu_map.rst: Korean added to the Language values.Verification
pybabel compile --statistics: 696/696 for de, es, fr, ko, zh.--display headless, 128×128) withlanguage: koand walked main menu, Settings → Chart/Language/User Pref, Objects → By Catalog, Tools → Equipment, SQM. No missing glyphs, no truncation at base font size.ruff checkon the five touched files;pytest -m smokepasses (web/Selenium tests skipped, no grid).Not addressed here
ko/zhback to a Latin language does not trigger a restart, so the CJK font stays loaded until the next boot. Pre-existing behaviour forzh; left as is.🤖 Generated with Claude Code
https://claude.ai/code/session_01WErqKyPNdq326xqryfMJLX