fix: retry transient failures for internal BTQL requests#2227
Open
Pedro Mora (stretpjc) wants to merge 2 commits into
Open
fix: retry transient failures for internal BTQL requests#2227Pedro Mora (stretpjc) wants to merge 2 commits into
Pedro Mora (stretpjc) wants to merge 2 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 80e5cfbe31
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bounded retries for semantically read-only BTQL POST requests used by
dataset/object fetching, span fetching, and prompt-version history.
Retry network failures and transient 500, 502, 503, and 504 responses with
exponential backoff and jitter while respecting cancellation. Retry behavior is
opt-in through the existing internal HTTP
post()method, so ordinary POST andwrite requests remain non-retrying.
No end-user code changes are required. Users receive the behavior automatically
after upgrading to a version containing this fix.
Add regression coverage that simulates a transient BTQL 500 followed by a
successful response. Also cover non-transient responses, aborted requests, and
ordinary POST behavior.
The underlying production backend failure is transient and cannot be reproduced
reliably on demand. The regression test reproduces the SDK-visible failure mode
using a controlled mocked response and verifies that the request now recovers.