Skip to content

Harden thread reply roleplay E2E #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TheSentinel454 wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −6
Draft

Harden thread reply roleplay E2E #5189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions desktop/tests/e2e/thread-reply-anchor-roleplay.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,25 @@ async function setupRoleplayChannel(page: import("@playwright/test").Page) {
await waitForMockLiveSubscription(page, CHANNEL);
}

async function openThread(page: import("@playwright/test").Page) {
const summary = page.getByTestId("message-thread-summary").first();
async function openThread(
page: import("@playwright/test").Page,
threadHeadId: string,
) {
const viewport = page.viewportSize();
if (!viewport) throw new Error("Missing viewport size");
await page.mouse.move(viewport.width - 1, 1);
await page.keyboard.press("Escape");
await expect(
page.getByTestId(`channel-activity-popover-${CHANNEL}`),
).toBeHidden();

const summary = page.locator(
`[data-testid="message-thread-summary"][data-thread-head-id="${threadHeadId}"]`,
);
await expect(summary).toBeVisible();
await summary.evaluate((element) =>
element.scrollIntoView({ block: "center", inline: "nearest" }),
);
await summary.click();
await expect(page.getByTestId("message-thread-panel")).toBeVisible();
}
Expand Down Expand Up @@ -200,7 +216,7 @@ test.describe("thread reply anchor A/B roleplay screenshots", () => {
},
);

await openThread(page);
await openThread(page, root.id);
await expandReply(page, humanReply.id);
await expect(page.getByText("Nora: adding context")).toBeVisible();
await expect(page.getByText("Pinky: Got it")).toBeVisible();
Expand Down Expand Up @@ -252,7 +268,14 @@ test.describe("thread reply anchor A/B roleplay screenshots", () => {
},
);

await openThread(page);
// Reproduce the CI timing where the pointer remains over #general long
// enough for its newly available activity preview to cover the timeline.
await page.getByTestId("channel-general").hover();
await expect(
page.getByTestId("channel-activity-popover-general"),
).toBeVisible();

await openThread(page, root.id);
await expect(page.getByText("Nora: adding context")).toBeVisible();
await expect(page.getByText("Pinky: Got it")).toBeVisible();
await expect(
Expand Down Expand Up @@ -291,7 +314,7 @@ test.describe("thread reply anchor A/B roleplay screenshots", () => {
},
);

await openThread(page);
await openThread(page, humanRoot.id);
await expect(page.getByText("Pinky: Starting the audit")).toBeVisible();
await expect(
page.getByTestId("message-thread-replies").getByTestId("message-row"),
Expand Down Expand Up @@ -337,7 +360,7 @@ test.describe("thread reply anchor A/B roleplay screenshots", () => {
},
);

await openThread(page);
await openThread(page, root.id);
await expandReply(page, brainReply.id);
await expect(page.getByText("Brain: Check the anchor")).toBeVisible();
await expect(page.getByText("Pinky: Good catch")).toBeVisible();
Expand Down
Loading