Harden thread reply roleplay E2E - #5189
Draft
TheSentinel454 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Luke Tornquist <tornquist@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The desktop smoke suite intermittently times out while opening a seeded thread. On slower runs, the pointer can remain over
#generallong enough for the channel activity popover to cover the thread summary; the composer can also overlap a summary near the bottom of the timeline. The roleplay test is meant to validate reply anchoring, so transient pointer placement and viewport position should not determine whether it reaches that assertion.What
Risk Assessment
Low — this changes only Playwright test interaction logic. Production code and behavior are unchanged.
Validation
just cipnpm build:e2eReferences
Generated with Codex