Skip to content

Harden thread reply roleplay E2E - #5189

Draft
TheSentinel454 wants to merge 1 commit into
block:mainfrom
TheSentinel454:codex/harden-thread-reply-e2e
Draft

Harden thread reply roleplay E2E#5189
TheSentinel454 wants to merge 1 commit into
block:mainfrom
TheSentinel454:codex/harden-thread-reply-e2e

Conversation

@TheSentinel454

Copy link
Copy Markdown
Contributor

Why

The desktop smoke suite intermittently times out while opening a seeded thread. On slower runs, the pointer can remain over #general long enough for the channel activity popover to cover the thread summary; the composer can also overlap a summary near the bottom of the timeline. The roleplay test is meant to validate reply anchoring, so transient pointer placement and viewport position should not determine whether it reaches that assertion.

What

  • Reproduce the activity-popover overlap in the formerly failing scenario
  • Select each seeded thread by its exact head event ID instead of the first summary in the timeline
  • Dismiss transient activity UI and center the target summary before clicking it

Risk Assessment

Low — this changes only Playwright test interaction logic. Production code and behavior are unchanged.

Validation

  • just ci
  • pnpm build:e2e
  • Thread reply roleplay smoke spec repeated five times: 20/20 passed

References

Generated with Codex

Signed-off-by: Luke Tornquist <tornquist@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant