Fix crashes in &blut, exact, speedup, and write_verilog - #570
Merged
Merged
Conversation
- &blut: reject LUT size outside [2, 15] to prevent assertion/NULL dereference. Reproducer: ./abc -c "r i10.aig; &get; &blut -K 16" - exact: bound -A arrival time list to 8 entries to prevent stack buffer overflow. Reproducer: ./abc -c "r i10.aig; exact -A $(seq -s, 1 150)" - speedup: return early if Abc_NtkDelayTraceLut fails (-ABC_INFINITY) instead of dereferencing unallocated timing data. Reproducer: ./abc -c "r i10.aig; if -K 8; speedup -l" - write_verilog: check both ABC_OBJ_PI and ABC_OBJ_NET for existing "clock" signal to avoid emitting duplicate clock ports on netlists. Reproducer: ./abc -c "r i10.aig; logic; pipe; write_verilog _tmp.v; read_verilog _tmp.v; write_verilog _tmp.v; read_verilog _tmp.v"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproducer: ./abc -c "r i10.aig; &get; &blut -K 16"
Reproducer: ./abc -c "r i10.aig; exact -A $(seq -s, 1 150)"
Reproducer: ./abc -c "r i10.aig; if -K 8; speedup -l"
Reproducer: ./abc -c "r i10.aig; logic; pipe; write_verilog _tmp.v; read_verilog _tmp.v; write_verilog _tmp.v; read_verilog _tmp.v"