Skip to content

fix: print c8's own version with yargs 18 #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
official-burak wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −2
Open

fix: print c8's own version with yargs 18 #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/parse-args.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ const Yargs = require('yargs/yargs')
const { applyExtends } = require('yargs/helpers')
const parser = require('yargs-parser')
const { resolve } = require('path')
const { version } = require('../package.json')

function buildYargs (withCommands = false) {
const yargs = Yargs([])
.usage('$0 [opts] [script] [opts]')
.version(version)
.options('config', {
alias: 'c',
config: true,
Expand Down
4 changes: 2 additions & 2 deletions test/integration.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ All files | 3.18 | 12.24 | 6.38 | 3.18
prettify.js | 0 | 0 | 0 | 0 | 1-2
sorter.js | 0 | 0 | 0 | 0 | 1-210
c8/lib | 0 | 0 | 0 | 0 |
parse-args.js | 0 | 0 | 0 | 0 | 1-229
parse-args.js | 0 | 0 | 0 | 0 | 1-231
report.js | 0 | 0 | 0 | 0 | 1-542
source-map-from-file.js | 0 | 0 | 0 | 0 | 1-100
c8/lib/commands | 0 | 0 | 0 | 0 |
Expand Down Expand Up @@ -532,7 +532,7 @@ All files | 3.18 | 12.24 | 6.38 | 3.18
prettify.js | 0 | 0 | 0 | 0 | 1-2
sorter.js | 0 | 0 | 0 | 0 | 1-210
c8/lib | 0 | 0 | 0 | 0 |
parse-args.js | 0 | 0 | 0 | 0 | 1-229
parse-args.js | 0 | 0 | 0 | 0 | 1-231
report.js | 0 | 0 | 0 | 0 | 1-542
source-map-from-file.js | 0 | 0 | 0 | 0 | 1-100
c8/lib/commands | 0 | 0 | 0 | 0 |
Expand Down
25 changes: 25 additions & 0 deletions test/parse-args.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ const {
hideInstrumenterArgs
} = require('../lib/parse-args')

const { spawnSync } = require('child_process')
const { mkdtempSync, writeFileSync } = require('fs')
const { tmpdir } = require('os')
const { join, resolve } = require('path')
const { version } = require('../package.json')

describe('parse-args', () => {
describe('hideInstrumenteeArgs', () => {
Expand Down Expand Up @@ -87,6 +91,27 @@ describe('parse-args', () => {
})
})

describe('--version', () => {
it('prints the c8 package version from a cwd whose package.json differs', () => {
const dir = mkdtempSync(join(tmpdir(), 'c8-version-'))
writeFileSync(join(dir, 'package.json'), JSON.stringify({
name: 'app',
version: '1.0.0'
}))
const env = { ...process.env }
delete env.NODE_V8_COVERAGE
const result = spawnSync(process.execPath, [require.resolve('../bin/c8'), '--version'], {
cwd: dir,
encoding: 'utf8',
env
})
result.status.should.equal(0)
result.stdout.trim().should.equal(version)
result.stdout.trim().should.not.equal('1.0.0')
result.stdout.trim().should.not.equal('unknown')
})
})

describe('--merge-async', () => {
it('should default to false', () => {
const argv = buildYargs().parse(['node', 'c8'])
Expand Down