fix: print c8's own version with yargs 18 - #608
Open
official-burak wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the yargs 18 bump in v12,
c8 --versionno longer reads this package's version. It printsunknown, or in some installs the consuming app's version, which is what #607 ran into.This sets
.version()from c8's own package.json so the CLI always reports the published version. The test runs the bin from a cwd whose package.json is1.0.0so we don't pick that up again.Fixes #607
Checklist
npm test, tests passingnpm run test:snap(to update the snapshot)