apps: replace atomic_fetch_xxx with atomic_xxx - #3733
Open
zhangyu-duck wants to merge 1 commit into
Open
Conversation
zhangyu-duck
force-pushed
the
pr-atomic-rename-new
branch
2 times, most recently
from
August 18, 2026 12:00
c10f785 to
0d3efce
Compare
Rename atomic_fetch_xxx to atomic_xxx (e.g., atomic_fetch_add -> atomic_add) and atomic_store/atomic_load to atomic_set/atomic_read, to match the <nuttx/atomic.h> API rename in the companion nuttx PR. The atomic_fetch_xxx naming is reserved by the C/C++ standard and conflicts with standard library declarations when <atomic>/ <stdatomic.h> is included by third-party code. Files changed: - crypto/openssl_mbedtls_wrapper/mbedtls/ssl_lib.c - testing/libc/atomic/atomic_main.c - testing/ostest/roundrobin.c - testing/ostest/spinlock.c Signed-off-by: zhangyu117 <zhangyu117@xiaomi.com>
zhangyu-duck
force-pushed
the
pr-atomic-rename-new
branch
from
August 18, 2026 12:04
0d3efce to
b11b455
Compare
zhangyu-duck
marked this pull request as ready for review
August 19, 2026 06:36
xiaoxiang781216
approved these changes
Aug 19, 2026
jerpelea
approved these changes
Aug 19, 2026
🔗 Cross-repo PR dependenciesThe read-only Build run reported the following dependent PR(s) and fetched head SHA(s): CI run: https://github.com/apache/nuttx-apps/actions/runs/32134898362 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename
atomic_fetch_xxxtoatomic_xxx(e.g.,atomic_fetch_add->atomic_add) andatomic_store/atomic_loadtoatomic_set/atomic_read, to match the<nuttx/atomic.h>API rename in the companion nuttx PR.The
atomic_fetch_xxxnaming is reserved by the C/C++ standard and conflicts with standard library declarations when<atomic>/<stdatomic.h>is included by third-party code.Files changed
crypto/openssl_mbedtls_wrapper/mbedtls/ssl_lib.ctesting/libc/atomic/atomic_main.ctesting/ostest/roundrobin.ctesting/ostest/spinlock.cCompanion PR
This is the apps companion to apache/nuttx#19867 (atomic: multi-backend framework + builtin + API rename).
depends-on: apache/nuttx/pull/19867