Skip to content

[4.18.x] Restore throttling of jobs per node on Jenkins - #26096

Merged
apupier merged 1 commit into
apache:camel-4.18.xfrom
apupier:camel-4.18.x-backportJekinsThrottling
Sep 4, 2026
Merged

[4.18.x] Restore throttling of jobs per node on Jenkins#26096
apupier merged 1 commit into
apache:camel-4.18.xfrom
apupier:camel-4.18.x-backportJekinsThrottling

Conversation

@apupier

@apupier apupier commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

seems that an upgrade of the jenkins plugin used changed the default value for maxConcurrentPerNode
jenkinsci/throttle-concurrent-builds-plugin@e761815 , so with this relase
https://github.com/jenkinsci/throttle-concurrent-builds-plugin/releases/tag/624.vc427fa_e0e503

When no value set previously, it was considering a value of one.

we are still not ready for playing the tests in //, there are still port conflicts and artifacts could overwrite them in the local repository causing wrong testing.

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

AI-assisted contributions

  • If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., Co-authored-by trailers) and the PR description identifies the AI tool used.

@apupier apupier changed the title Restore throttling of jobs per node on Jenkins [4.18.x] Restore throttling of jobs per node on Jenkins Sep 3, 2026
@apupier
apupier marked this pull request as ready for review September 3, 2026 15:14

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct backport of #26094 to camel-4.18.x. Only one Jenkinsfile on this branch (no Jenkinsfile.jdk26), which is expected.

Same nit as the other PRs: trailing blank line after maxConcurrentPerNode: 1.

This review was generated by an automated reviewer (Hermès) on behalf of @gnodet.

Comment thread Jenkinsfile
categories: ['camel'],
throttleEnabled: true,
throttleOption: 'category'
throttleOption: 'category',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: trailing blank line before the closing ).

Suggested change
throttleOption: 'category',
maxConcurrentPerNode: 1

seems that an upgrade of the jenkins plugin used changed the default
value for maxConcurrentPerNode
jenkinsci/throttle-concurrent-builds-plugin@e761815
, so with this relase
https://github.com/jenkinsci/throttle-concurrent-builds-plugin/releases/tag/624.vc427fa_e0e503

When no value set previously, it was considering a value of one.

we are still not ready for playing the tests in //, there are still port
conflicts and artifacts could overwrite them in the local repository
causing wrong testing.

Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@apupier
apupier force-pushed the camel-4.18.x-backportJekinsThrottling branch from 1d9a3fd to 2bf0334 Compare September 3, 2026 15:53

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after new commits. The change correctly restores maxConcurrentPerNode: 1 to compensate for the Jenkins throttle-concurrent-builds-plugin default change (from 1 to 0/unlimited in 624.vc427fa). Groovy syntax is correct.

Note: the previous review flagged a trailing blank line nit, but that blank line between ) and the next comment is pre-existing on the camel-4.18.x branch — not introduced by this PR. Withdrawing that nit.

This review was generated by an automated reviewer (Hermès) on behalf of @gnodet.

@apupier
apupier merged commit 26b9a88 into apache:camel-4.18.x Sep 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants