Restore throttling of jobs per node on Jenkins - #26094
Conversation
38cead2 to
dd3190c
Compare
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet
left a comment
There was a problem hiding this comment.
Straightforward fix — explicitly setting maxConcurrentPerNode: 1 after the throttle-concurrent-builds-plugin upgrade changed the default is the right call. The linked upstream commit confirms the parameter name and the behavior change.
One minor nit: there's a trailing blank line at line 44 in Jenkinsfile that isn't present in Jenkinsfile.jdk26. Not a blocker, but inconsistent.
Backports to 4.22.x (#26095) and 4.18.x (#26096) are already open. ✓
This review was generated by an automated reviewer (Hermès) on behalf of @gnodet.
| categories: ['camel'], | ||
| throttleEnabled: true, | ||
| throttleOption: 'category' | ||
| throttleOption: 'category', |
There was a problem hiding this comment.
Nit: trailing blank line. Jenkinsfile.jdk26 doesn't have it — the two files should be consistent.
| throttleOption: 'category', | |
| maxConcurrentPerNode: 1 |
seems that an upgrade of the jenkins plugin used changed the default value for maxConcurrentPerNode jenkinsci/throttle-concurrent-builds-plugin@e761815 , so with this relase https://github.com/jenkinsci/throttle-concurrent-builds-plugin/releases/tag/624.vc427fa_e0e503 When no value set previously, it was considering a value of one. we are still not ready for playing the tests in //, there are still port conflicts and artifacts could overwrite them in the local repository causing wrong testing. Signed-off-by: Aurélien Pupier <apupier@ibm.com>
dd3190c to
b272792
Compare
seems that an upgrade of the jenkins plugin used changed the default value for maxConcurrentPerNode
jenkinsci/throttle-concurrent-builds-plugin@e761815 , so with this relase
https://github.com/jenkinsci/throttle-concurrent-builds-plugin/releases/tag/624.vc427fa_e0e503
When no value set previously, it was considering a value of one.
we are still not ready for playing the tests in //, there are still port conflicts and artifacts could overwrite them in the local repository causing wrong testing.
Description
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.AI-assisted contributions
Co-authored-bytrailers) and the PR description identifies the AI tool used.