Skip to content

Restore throttling of jobs per node on Jenkins - #26094

Merged
apupier merged 1 commit into
apache:mainfrom
apupier:restoreThrottlingOnJenkinsAfterDefaultValueChange
Sep 4, 2026
Merged

Restore throttling of jobs per node on Jenkins#26094
apupier merged 1 commit into
apache:mainfrom
apupier:restoreThrottlingOnJenkinsAfterDefaultValueChange

Conversation

@apupier

@apupier apupier commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

seems that an upgrade of the jenkins plugin used changed the default value for maxConcurrentPerNode
jenkinsci/throttle-concurrent-builds-plugin@e761815 , so with this relase
https://github.com/jenkinsci/throttle-concurrent-builds-plugin/releases/tag/624.vc427fa_e0e503

When no value set previously, it was considering a value of one.

we are still not ready for playing the tests in //, there are still port conflicts and artifacts could overwrite them in the local repository causing wrong testing.

Description

Target

  • I checked that the commit is targeting the correct branch (Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally from root folder and I have committed all auto-generated changes.

AI-assisted contributions

  • If this PR includes AI-generated code, commits have proper co-authorship attribution (e.g., Co-authored-by trailers) and the PR description identifies the AI tool used.

@apupier
apupier force-pushed the restoreThrottlingOnJenkinsAfterDefaultValueChange branch from 38cead2 to dd3190c Compare September 3, 2026 14:58
@github-actions github-actions Bot added the ci label Sep 3, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@apupier
apupier marked this pull request as ready for review September 3, 2026 15:14

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward fix — explicitly setting maxConcurrentPerNode: 1 after the throttle-concurrent-builds-plugin upgrade changed the default is the right call. The linked upstream commit confirms the parameter name and the behavior change.

One minor nit: there's a trailing blank line at line 44 in Jenkinsfile that isn't present in Jenkinsfile.jdk26. Not a blocker, but inconsistent.

Backports to 4.22.x (#26095) and 4.18.x (#26096) are already open. ✓

This review was generated by an automated reviewer (Hermès) on behalf of @gnodet.

Comment thread Jenkinsfile
categories: ['camel'],
throttleEnabled: true,
throttleOption: 'category'
throttleOption: 'category',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: trailing blank line. Jenkinsfile.jdk26 doesn't have it — the two files should be consistent.

Suggested change
throttleOption: 'category',
maxConcurrentPerNode: 1

seems that an upgrade of the jenkins plugin used changed the default
value for maxConcurrentPerNode
jenkinsci/throttle-concurrent-builds-plugin@e761815
, so with this relase
https://github.com/jenkinsci/throttle-concurrent-builds-plugin/releases/tag/624.vc427fa_e0e503

When no value set previously, it was considering a value of one.

we are still not ready for playing the tests in //, there are still port
conflicts and artifacts could overwrite them in the local repository
causing wrong testing.

Signed-off-by: Aurélien Pupier <apupier@ibm.com>
@apupier
apupier force-pushed the restoreThrottlingOnJenkinsAfterDefaultValueChange branch from dd3190c to b272792 Compare September 3, 2026 15:55
@apupier
apupier requested a review from gnodet September 4, 2026 06:44
@apupier
apupier merged commit 85365d3 into apache:main Sep 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants