Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion node.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ func parseValue(x interface{}, top *Node, level int) {
}
default:
// JSON types: string, number, boolean
n := &Node{Data: fmt.Sprintf("%v", v), Type: TextNode, level: level, value: fmt.Sprintf("%v", v)}
n := &Node{Data: fmt.Sprintf("%v", v), Type: TextNode, level: level, value: v}
addNode(n)
}
}
Expand Down
28 changes: 28 additions & 0 deletions node_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,34 @@ func TestParseJsonObject(t *testing.T) {
}
}

func TestTextNodeValuePreservesJSONType(t *testing.T) {
doc, err := parseString(`{"count": 12, "enabled": true, "name": "sensor"}`)
if err != nil {
t.Fatal(err)
}
for _, tc := range []struct {
name string
value interface{}
text string
}{
{"count", float64(12), "12"},
{"enabled", true, "true"},
{"name", "sensor", "sensor"},
} {
parent := doc.SelectElement(tc.name)
if parent == nil || parent.FirstChild == nil || parent.FirstChild.Type != TextNode {
t.Fatalf("missing text node for %s", tc.name)
}
child := parent.FirstChild
if got := child.Value(); !reflect.DeepEqual(got, tc.value) {
t.Errorf("%s text value = %v (%T), want %v (%T)", tc.name, got, got, tc.value, tc.value)
}
if child.Data != tc.text || parent.InnerText() != tc.text {
t.Errorf("%s rendered text changed: data=%q inner=%q", tc.name, child.Data, parent.InnerText())
}
}
}

func TestParseJsonObjectArray(t *testing.T) {
s := `[
{"models":[ "Fiesta", "Focus", "Mustang" ] }
Expand Down