Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20. Text nodes currently retain only a formatted string in their internal value, so
Value()returns"12"for a JSON number and"true"for a JSON boolean. This differs from the typed value returned by their parent element and makes direct text-node selections lose JSON scalar types.Keep the original decoded scalar as the text node's value while leaving
Dataas the display string. A regression first failed for numeric and boolean nodes, then passed with this change; it also checks that rendered text remains unchanged. Localgo test ./...,go test -race ./...,go vet ./..., and diff check pass with Go 1.27.1. Remote CI is not yet verified. Prepared with AI assistance and reviewed against XPath navigation and rendering callers.