feat(app): show writing command state - #44095
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Writing command...while shell input is still streaming and has not parsed into a commandShellshimmering through streamed-input parsing, then make it static when execution startsFigma: section
1769:236652; writing1842:10023; command ready1842:9937; running1842:10255; hover1842:10420; expanded1842:11309.Testing
bun typecheckinpackages/app,packages/session-ui, andpackages/uibun testinpackages/session-ui(91 passed)bun testinpackages/ui(27 passed)tool.input.started->tool.input.ended->tool.calledPerformance
The production benchmark was run before and after. Both runs built successfully, then hit the existing blank-app readiness failure before fixture setup; neither emitted metrics.
Known base issue
bun run typecheck:e2eretains the existing error insession-timeline-notices.spec.ts:82:toolPart(...)returns aToolSeedwithout the protocol tool part's requiredtime. This PR adds no E2E type errors.