feat(app): fade the background move hint - #44109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Press ⌘B to move running work to the background" hint now fades when its visibility changes on an already-mounted timeline. Initial page and tab mounts render it immediately without animation.
`solid-presence` keeps the row mounted until the exit animation finishes. A memo seeded with the initial visibility distinguishes mounting from later enter/exit transitions.
This also restores the active shimmer for backgrounded shell tasks. The current `v2` base regressed that state in #44095 by checking only `streaming`; backgrounded shells use a completed tool state with `metadata.status === "running"`, which caused this PR's initial E2E checks to fail before exercising the fade.
Verification: