Set impl_1 strategy before sourcing pre-synth Tcl#133
Draft
merkelmarrow wants to merge 1 commit into
Draft
Conversation
Setting the run strategy resets all STEPS.* options to the strategy defaults, so applying it after the pre-synth scripts silently removes any per-step directive overrides (STEPS.*.ARGS.DIRECTIVE) a user set on impl_1. Apply the default strategy first so pre-synth scripts can override individual step options on top of it. Signed-off-by: Marco Blackwell <mblackwe@amd.com>
merkelmarrow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
slash_project_build.tcl, the default implementation strategy was applied to impl_1 after the user's pre-synth Tcl scripts were sourced. Becauseset_property strategy ...resets everySTEPS.*option on the run to the strategy's defaults, any per-step directive a pre-synth script set was silently removed beforelaunch_runs impl_1.This moves the strategy assignment ahead of the pre-synth sourcing loop so the strategy is the baseline and pre-synth scripts can override individual step options on top of it.
Testing pending.