Repository navigation
Use backend URLs in shared invalid-JSON tests - #3749
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared invalid-JSON tests and their body-rejection helper identify the query API by its production hostname. Pass the backend's
base_vwq_urlfixture into the helper and use it to select the query-specific expectations, including malformed bodies sent with skewed dates. The same assertions can then run at custom service URLs.This two-file follow-up to #3748 advances #3738, part of #3737. Further URL and backend decoupling remains in #3738.
Validation:
MockVWSconfigured athttp://127.0.0.1:5006andhttp://127.0.0.1:5007: 92 cases pass, with seven expected skips for endpoints that do not take JSON.git diff --checkpasses.Full-suite coverage and real-Vuforia validation remain for hosted CI.