Repository navigation
Complete shared query URL fixture wiring - #3750
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the remaining shared query URL wiring in one change. Query request helpers and every caller now receive
base_vwq_url; direct query requests, bad-key clients, configurable failure-response tests, and the remaining endpoint classifiers use the same fixture. Backend setup configures bothMockVWSand the Flask adapters with the supplied service URLs, including the VWS URL needed by query setup and locally constructed VWS clients.This advances #3738, part of #3737. It is independent of the invalid-JSON changes in #3749, which was awaiting auto-merge when this work started. The remaining production query URL literals represent the central default, deliberate default-URL regression inputs, an asserted Vuforia error-page body, or the real-service timeout policy.
Validation:
http://127.0.0.1:5006andhttp://127.0.0.1:5007, and passes 230 cases with 118 expected skips. It reuses the existing assertions and adapter setup, so it verifies the URL overrides through both mock implementations.git diff --checkpasses.Both local test runs use synthetic credentials and disable pytest retries.