Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a serial driver for the FilterMax F5 plate reader.
The driver supports:
Commands wait until the active operation and its cleanup are complete. Cancellation stops a measurement after the current device message is complete. The driver rejects incomplete messages and reports device errors.
The PR includes a Hello World notebook, an example filter catalog, API documentation, and a protocol coverage guide. Automated tests cover startup, message parsing, queued commands, cancellation, and recovery.
All 60 FilterMax tests passed. Type checking passed for all 986 Python files. The Hello World notebook was also tested on a real FilterMax F5. The protocol guide records the hardware test results and their limits.
Fluorescence modes are not yet supported. Manufacturer performance qualification was not performed.