Repository navigation
fix: menus open like the other popovers, themed disclosures and a quiet sidebar scrollbar (0.4.2) - #15
Merged
Conversation
…et sidebar scrollbar (0.4.2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings from a UI audit of Strata, released as 0.4.2.
Menus
Menunow uses the same anchored top-layer panel asSelect. Before, it was absolutely positioned under its trigger, so long menus ran off the screen and could not scroll. Strata's "Add widget" menu ended about 190px below the window.align: 'end'option onuseAnchoredPanel. They flip upwards when there is no room below and scroll when taller than the window. The phone-only fixed position is gone, because anchoring covers it.Disclosures
<details>/<summary>use the interface's chevron instead of the browser's triangle and rotate it when open.Sidebar scrollbar
Version 0.4.2 (package, lock file and the README install line). Tag
v0.4.2on the merge commit to publish.Tests: new case in
test/popovers.spec.tsx(pointer open, no highlighted item). Rantest/popovers.spec.tsx,test/workspace.spec.tsx,test/controls.spec.tsxandtest/shell.spec.tsx, plus lint and build. Checked in Strata at 1440px and 390px: "Add widget", every widget menu, a space's row menu and the account menu all stay on screen.