Repository navigation
fix: layouts that broke on phones, even form spacing and graphite-ui 0.4.2 - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from a UI audit for components that overlap or push each other out of place. Every page was checked at 1440px and 390px wide, with a script that compares element boxes and looks for sideways scrolling. Each create dialog and popover was also opened at phone width.
Dependency:
@project-graphite/ui0.4.0 → 0.4.2 (our own package):<details>; the sidebar scrollbar shows only on hover.Phone layouts
Toolbaractions can wrap. The space Pages tab's three buttons used to run 41px past the screen edge.Even spacing in forms
gap-y-1(orgap-3) while their forms usedgap-4. Every field already reserves a line for its message, so on phones, where the rows stack, the space between fields changed partway down a form.gap-4: event, task and statement-import dialogs, Profile, dashboard settings and tagging rules.API reference
The audit found no remaining overlaps or sideways scrolling, and every dialog fits at 390px.
Ran
test/dashboard,tasks,spaces,tidy,habits,notes,invitations,settings,api-settings,tokens,agenda,subscriptionsandstatementspecs, plustsc -b, oxlint and the frontend build.