Skip to content

fix: layouts that broke on phones, even form spacing and graphite-ui 0.4.2 - #100

Merged
AmrMsCLL merged 1 commit into
mainfrom
fix/ui-audit
Oct 11, 2026
Merged

AmrMsCLL merged 1 commit into
mainfrom
fix/ui-audit

Conversation

@AmrMsCLL

Copy link
Copy Markdown
Member

Fixes from a UI audit for components that overlap or push each other out of place. Every page was checked at 1440px and 390px wide, with a script that compares element boxes and looks for sideways scrolling. Each create dialog and popover was also opened at phone width.

Dependency: @project-graphite/ui 0.4.0 → 0.4.2 (our own package):

Phone layouts

  • Toolbar actions can wrap. The space Pages tab's three buttons used to run 41px past the screen edge.
  • Member rows wrap the role picker and Leave/Remove under the name. They used to make the Members tab 152px wider than the screen.
  • Tagging-rule rows wrap the same way.

Even spacing in forms

  • Two-column field rows used gap-y-1 (or gap-3) while their forms used gap-4. Every field already reserves a line for its message, so on phones, where the rows stack, the space between fields changed partway down a form.
  • All field rows now use the form's gap-4: event, task and statement-import dialogs, Profile, dashboard settings and tagging rules.
  • Name and colour fields use the same gap too.

API reference

  • The endpoint disclosures keep their label together next to the new chevron.

The audit found no remaining overlaps or sideways scrolling, and every dialog fits at 390px.

Ran test/dashboard, tasks, spaces, tidy, habits, notes, invitations, settings, api-settings, tokens, agenda, subscriptions and statement specs, plus tsc -b, oxlint and the frontend build.

@github-actions github-actions Bot added the size/s 11-50 changed lines, excluding lockfiles label Oct 11, 2026
@AmrMsCLL
AmrMsCLL merged commit 0a43ee6 into main Oct 11, 2026
7 checks passed
@AmrMsCLL
AmrMsCLL deleted the fix/ui-audit branch October 11, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s 11-50 changed lines, excluding lockfiles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant