Repository navigation
fix: stop focus rings on open lists and the 1px page scroll from the header border (0.4.1) - #14
Merged
Merged
Conversation
…header border (0.4.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs reported in Strata, released as 0.4.1.
Focus ring on every open dropdown. The global
:focus-visiblerule sat outside any cascade layer, so it beat every rule in@layer components, whatever its specificity. Theoutline: noneon the list search box, the option list, menu items, grid options and the command input never applied. Opening a searchable select showed a bright ring around its search box. The rule now lives in@layer base, so those component rules work as written. Keyboard focus is still visible everywhere else, and inside lists the active option stays highlighted.Pages scrolled by 1px. The header's bar was
h-16with a 1px border on top of that, so the header measured 65px. The sticky sidebar and dropdown offsets assume--header-height(64px), so the sidebar ended 1px below the window, and every short page scrolled by 1px. The header is now exactly--header-heighttall, border included.Version 0.4.1 (package, lock file and the README install line). Tag
v0.4.1on the merge commit to publish.Ran
test/shell.spec.tsx,test/workspace.spec.tsx,test/controls.spec.tsxandtest/popovers.spec.tsx, plus lint and build. Checked in Strata: a short page no longer scrolls, the header measures 64px, and the time zone search opens without a ring.