Skip to content

print "Loading facts" just once #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bastelfreak merged 3 commits into from
Sep 10, 2026
Merged

print "Loading facts" just once #656

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
651fd76
print "Loading facts" just once
bastelfreak Sep 8, 2026
8a688db
facter.rb: Fix typo
bastelfreak Sep 8, 2026
b7893be
restructure debug logging
bastelfreak Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions lib/puppet/indirector/facts/facter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,21 +62,22 @@ def self.setup_search_paths(request)
end
end.flatten + Puppet[:factpath].split(File::PATH_SEPARATOR)

dirs = dirs.select do |dir|
next false unless FileTest.directory?(dir)

# Even through we no longer directly load facts in the terminus,
# print out each .rb in the facts directory as module
# developers may find that information useful for debugging purposes
if Puppet::Util::Log.sendlevel?(:info)
Puppet.info _("Loading facts")
Dir.glob("#{dir}/*.rb").each do |file|
Puppet.debug { "Loading facts from #{file}" }
dirs.select! { |dir| FileTest.directory?(dir) }

# Even though we no longer directly load facts in the terminus,
# print out each .rb in the facts directory as module
# developers may find that information useful for debugging purposes
unless dirs.empty?
Puppet.info _("Loading facts")
if Puppet::Util::Log.sendlevel?(:debug)
dirs.each do |dir|
Dir.glob("#{dir}/*.rb").each do |file|
Puppet.debug { "Loading facts from #{file}" }
end
end
end

true
end

dirs << request.options[:custom_dir] if request.options[:custom_dir]
Puppet.runtime[:facter].search(*dirs)
end
Expand Down