print "Loading facts" just once - #656
Merged
Merged
Conversation
bastelfreak
force-pushed
the
logging
branch
2 times, most recently
from
September 8, 2026 11:38
ec26499 to
d22a7d5
Compare
miharp
reviewed
Sep 8, 2026
miharp
left a comment
miharp
left a comment
Contributor
There was a problem hiding this comment.
Mostly claude suggesting and me validating it works as described.
in the past, we printed "Loading facts" for every directory where we search for facts. This just created a bunch of noise. Co-authored-by: Michael Harp <mike@mikeharp.com> Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Co-authored-by: Michael Harp <mike@mikeharp.com> Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Co-authored-by: Michael Harp <mike@mikeharp.com> Signed-off-by: Tim Meusel <tim@bastelfreak.de>
Contributor
Author
|
@miharp could you have a second look please? |
miharp
approved these changes
Sep 8, 2026
miharp
left a comment
miharp
left a comment
Contributor
There was a problem hiding this comment.
once merged I will follow up with a PR adding coverage for the new logging behavior to keep this small and focused.
miharp
approved these changes
Sep 9, 2026
sebastianrakel
approved these changes
Sep 10, 2026
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the past, we printed "Loading facts" for every directory where we search for facts. This just created a bunch of noise.
Short description
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent