chore: fix spelling across comments, identifiers and query tags - #448
Open
NickJosevski wants to merge 1 commit into
Open
chore: fix spelling across comments, identifiers and query tags#448NickJosevski wants to merge 1 commit into
NickJosevski wants to merge 1 commit into
Conversation
Rebases the corrections from #204 onto main. Two are behavioural rather than cosmetic: the events query sent "interal" so the Internal filter never reached the server, and ManualInterverventionApprove gains a correctly spelled name while the misspelling stays as a deprecated alias. Co-Authored-By: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Closed
jsoref
reviewed
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #204, which had gone stale and conflicting. Same corrections, rebased onto
main, with @jsoref credited as co-author.Mostly comments and local identifiers, but two are behaviour, not spelling:
pkg/events/events_query.go—Internalwas taggeduri:"interal". The server's template is/api/events{?...,internal,...}, so the tag never matched and the filter silently expanded to nothing. Confirmed against a live instance. Same class as Feat: Add GetDashboard for the non-dynamic dashboard endpoint #442, [BUG] ReleaseTemplateGitResource.GitCredentialId has the wrong JSON tag and never deserialises #443 and [BUG] DeploymentProcessService.Get returns an empty process and a nil error when the project's Links are unpopulated #444.pkg/interruptions/interruption.go—ManualInterverventionApproveis exported, so chore: Spelling #204's outright rename would have been breaking. AddedManualInterventionApproveand kept the misspelling as a deprecated alias instead.pkg/machines/ssh_endpoint.goonly renames a field on a local struct insideMarshalJSON; itsjsontag was already correct, so nothing changes on the wire.Deliberately omitted from #204's set:
pkg/machines/duration_formatter_test.go(fourtySevenHours). #435 rewrites that file, and touching it here would only create a conflict — worth picking up after that merges.Verified
go build,go vet,gofmtclean on every file touched, andapi/spec.jsonstill parses. The fullpkg/...suite has the same failures before and after this change — all integration tests against a live instance, and the set varies between consecutive runs onmainalone.🤖 Generated with Claude Code