chore: Spelling - #204
Conversation
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
There was a problem hiding this comment.
The changes probably can't be made, but they're unfortunate, and I'm using this PR to call them out...
There was a problem hiding this comment.
This device is being used by a 9 yr old kid right now. I don't want to be mistreated again as what happened before.
No cla signet yet.
| } | ||
|
|
||
| // SetPrivateKeyPassphrase sets the private key [assphrase of this SSH key pair account. | ||
| // SetPrivateKeyPassphrase sets the private key passphrase of this SSH key pair account. |
| IDs []string `uri:"ids,omitempty" url:"ids,omitempty"` | ||
| IncludeSystem bool `uri:"includeSystem,omitempty" url:"includeSystem,omitempty"` | ||
| Internal string `uri:"interal,omitempty" url:"interal,omitempty"` | ||
| Internal string `uri:"internal,omitempty" url:"internal,omitempty"` |
There was a problem hiding this comment.
Changes like this are scary, as it's an API of sorts...
| } | ||
|
|
||
| const ManualInterverventionApprove = "Proceed" | ||
| const ManualInterventionApprove = "Proceed" |
There was a problem hiding this comment.
This is probably an API of sorts and thus probably can't be done either.
| sshEndpoint := struct { | ||
| AccountID string `json:"AccountId,omitempty"` | ||
| ComunicationStyle string `json:"CommunicationStyle" validate:"required,eq=Ssh"` | ||
| CommunicationStyle string `json:"CommunicationStyle" validate:"required,eq=Ssh"` |
| } | ||
| if result.explode && result.truncate > 0 { | ||
| err = errors.New("both explode and prefix modifers on same term") | ||
| err = errors.New("both explode and prefix modifiers on same term") |
There was a problem hiding this comment.
I'm hoping nothing cares about the spelling of error messages.
|
No CLA Signed yet. |
|
Octo deployment is not clear. No assistance received ever. |
|
Continue blocked the merging. |
|
Thanks @jsoref, and apologies this sat so long. Carried forward to #448, rebased onto Closing in favour of #448. |
3 participants
I'm skipping conventional commits for now, I'm happy to apply such conventions once the general content is discussed. I expect some of the items I'm flagging here can't be done...