Skip to content

chore(codeowners): disable wildcard ownership rule #3168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
purp wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −2
Draft

chore(codeowners): disable wildcard ownership rule #3168

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aca565
chore(codeowners): disable wildcard ownership rule
purp Sep 3, 2026
66243cc
chore(codeowners): own the approval machinery explicitly
purp Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
# Broad ownership — core team reviews everything
* @NVIDIA/openshell-codeowners @mrunalp @sjenning @derekwaynecarr
# Broad ownership — disabled. This rule matched every pull request and

@krishicks krishicks Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to delete the lines rather than comment them out.

# requested review from the whole codeowners team plus three individuals,
# notifying all of them regardless of what the change touched. Reviewers
# opt in manually until area/topic labeling and per-area maintainer
# rosters replace it with targeted routing. Do not restore as-is.
# * @NVIDIA/openshell-codeowners @mrunalp @sjenning @derekwaynecarr

# Vouch list — maintainers only (bot commits bypass, but manual edits need review)
.github/VOUCHED.td @NVIDIA/openshell-codeowners

# Approval machinery — these files decide who can merge. MAINTAINERS.md is the
# approver list itself; the workflow and helper below evaluate it and publish
# "OpenShell / Core Approval". A change to any of them silently redefines who
# can approve anything, so each keeps an explicit owner after the wildcard above
# was disabled. Scoped to these paths on purpose — owning all of .github/ would
# reintroduce the fan-out this file just removed.
/MAINTAINERS.md @NVIDIA/openshell-codeowners
/.github/CODEOWNERS @NVIDIA/openshell-codeowners
/.github/workflows/core-approval.yml @NVIDIA/openshell-codeowners
/.github/zizmor.yml @NVIDIA/openshell-codeowners
/tasks/scripts/core_approval.py @NVIDIA/openshell-codeowners
Loading