chore(codeowners): disable wildcard ownership rule - #3168
Draft
purp wants to merge 2 commits into
Draft
Conversation
purp
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 3, 2026 18:57
The `*` rule matched every pull request and requested review from the 11-member openshell-codeowners team plus three named individuals, notifying all of them regardless of what the change touched. Comment the rule out rather than delete it so the prior ownership set stays visible while reviewers opt in manually. Ownership of `.github/VOUCHED.td` is retained so manual edits to the vouch list still require maintainer review. Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
purp
force-pushed
the
chore/codeowners-review-noise/purp
branch
from
September 3, 2026 19:01
b88642e to
4aca565
Compare
purp
changed the title
johntmyers
previously approved these changes
Sep 3, 2026
purp
marked this pull request as draft
September 3, 2026 19:32
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
Looking at this further, it overly broadens who can approve PRs landing (from 14 to 56 ppl) so I'm moving this to draft while I see if there are any more straightforward noise reduction choices available. |
krishicks
requested changes
Sep 3, 2026
| @@ -1,5 +1,9 @@ | |||
| # Broad ownership — core team reviews everything | |||
| * @NVIDIA/openshell-codeowners @mrunalp @sjenning @derekwaynecarr | |||
| # Broad ownership — disabled. This rule matched every pull request and | |||
Collaborator
There was a problem hiding this comment.
Prefer to delete the lines rather than comment them out.
johntmyers
self-requested a review
September 3, 2026 22:21
Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables the
*rule in.github/CODEOWNERS, which matched every pull request and requested review from the 11-member@NVIDIA/openshell-codeownersteam plus three named individuals regardless of what the change touched. The rule is commented rather than deleted so the prior ownership set stays visible. Reviewers opt in until area/topic-based routing lands.With the wildcard gone, a handful of paths still need explicit owners: the files that decide who can approve anything. This PR adds them.
Related Issue
No issue required. This does not touch OpenShell platform code — it is maintenance of the project's own review machinery, and is non-breaking as merged.
Depends on the
core-approvalrequired status check landing and being registered on ruleset13332227first. Merging this before that leaves a window with neither gate enforcing.Changes
* @NVIDIA/openshell-codeowners @mrunalp @sjenning @derekwaynecarrwildcard rule and document why it is disabled..github/VOUCHED.tdso manual edits to the vouch list still require maintainer review.MAINTAINERS.md,.github/CODEOWNERS,.github/workflows/core-approval.yml,.github/zizmor.yml, andtasks/scripts/core_approval.py. A change to any of these silently redefines who can approve, so each keeps an owner after the wildcard is disabled. All entries are path-anchored (/MAINTAINERS.md, notMAINTAINERS.md) so a bare filename cannot match a nested path. Scoped to these five paths on purpose: owning all of.github/would reintroduce the fan-out this PR removes.Testing
mise run pre-commitpassesVerified
require_code_owner_reviewis set in both the legacy branch protection onmainand themainruleset (id13332227). Both stay enabled. With no owner matching most paths the requirement is vacuously satisfied, so PRs continue to merge on the existing single-approval rule;.github/VOUCHED.tdand the approval machinery remain gated.Checklist
Interim step. Area/topic auto-labeling with per-area maintainer rosters is planned over the next week or so and will replace this with targeted routing.