Skip to content

changes according copilot #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zaihuaji merged 1 commit into from
Mar 23, 2026
Merged

changes according copilot #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rda_python_common/pg_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ def get_command_info(pgrec):
otype, dsid, action, and specialist fields.

Returns:
str: A concise string such as 'Rqst42 ds123.0 ST of jsmith'.
str: A concise string such as 'Rqst42 d123000 ST of jsmith'.
"""
if pgrec['oindex']:
if pgrec['command'] == "dsupdt":
Expand Down
6 changes: 3 additions & 3 deletions src/rda_python_common/pg_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def __init__(self):
# The third hash value define bit flags,
# For Action Options:
# -1 - VSN card actions
# >0 - setions
# >0 - set actions
#
# For Mode Options:
# 1 - mode for archiving actions
Expand All @@ -92,7 +92,7 @@ def __init__(self):
# 128(0x080) - '' allowed for single letter value
# 256(0x100) - date field
#
# The fourth hash values defined retrictions for single letter values
# The fourth hash values defined restriction for single letter values

Copilot AI Mar 23, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment still has grammatical/spelling issues: "values" should agree with the verb, and the meaning appears to be plural ("restrictions"). Consider rephrasing to something like "The fourth hash value defines restrictions for single-letter values".

Suggested change
# The fourth hash values defined restriction for single letter values
# The fourth hash value defines restrictions for single-letter values.

Copilot uses AI. Check for mistakes.
###############################################################################
self.OPTS = {}
# global initial optional values
Expand Down Expand Up @@ -1669,7 +1669,7 @@ def get_control_frequency(frequency):
else:
errmsg = "invalid frequency '{}', unit must be (Y,M,W,D,H,N,S)".format(frequency)
return (None, errmsg)
freq = [0]*7 # initialize the frequence list
freq = [0]*7 # initialize the frequency list
uidx = {'Y': 0, 'D': 2, 'H': 3, 'N': 4, 'S': 5}
if unit == 'M':
freq[1] = val
Expand Down
Loading