changes according copilot - #95
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates inline documentation/comments in the RDA Python common utilities to correct typos and align dataset-id examples with the codebase’s preferred format.
Changes:
- Fix typo in option-flag documentation in
pg_opt.py(“setions” → “set actions”). - Fix typo in frequency parsing comment in
pg_opt.py(“frequence” → “frequency”). - Update
get_command_infodocstring example inpg_cmd.pyto use ad123000-style dataset ID.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/rda_python_common/pg_opt.py |
Comment/docstring typo fixes in option metadata docs and frequency parsing comment. |
src/rda_python_common/pg_cmd.py |
Docstring example updated for dataset-id format in get_command_info. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # 256(0x100) - date field | ||
| # | ||
| # The fourth hash values defined retrictions for single letter values | ||
| # The fourth hash values defined restriction for single letter values |
There was a problem hiding this comment.
This comment still has grammatical/spelling issues: "values" should agree with the verb, and the meaning appears to be plural ("restrictions"). Consider rephrasing to something like "The fourth hash value defines restrictions for single-letter values".
Suggested change
| # The fourth hash values defined restriction for single letter values | |
| # The fourth hash value defines restrictions for single-letter values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.