Conversation
…ent=pi Add compatibility layer for Gentle AI upstream patch supporting the new execute-native flow for reviewer capture: - lib/review-host-relay.ts: Add ReviewHostRelayExecuteSlot interface, isReviewHostRelayExecuteInput() classifier, and reviewHostRelayExecuteSlots() extractor for execute=true + agent=pi routing - lib/native-review-cli.ts: Add CAPTURE_EXECUTE operation, types, decoder, and captureExecute() method for the native Go-owned reviewer capture flow - extensions/gentle-ai.ts: Add execute routing between materialize and correction-plan checks, with executeReviewHostRelayExecuteCapture() function mirroring the provider role vector pattern - tests/review-host-relay-routing.test.ts: Add 5 tests covering execute capture success, closure response, parameter rejection, unsupported surface, and failure reporting The execute vector is self-contained: Go materializes the prompt, spawns its locked-down pi subprocess, and admits the raw verdict. The host never materializes, launches pi, or submits - it runs one CLI invocation verbatim.
…ent=pi Capture the provider metadata bound for the host relay execute slot, generalize captureProviderRole into a self-contained native method, and route the new execute slots while preserving legacy materialize+submission. Add focused tests.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe relay adds a self-contained execute capture vector for Pi and ChangesExecute-native capture routing
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ReviewCollectInput
participant ReviewHostRelay
participant NativeCaptureExecute
participant StatusReconciliation
ReviewCollectInput->>ReviewHostRelay: submit Pi execute capture input
ReviewHostRelay->>NativeCaptureExecute: invoke captureExecute with capture arguments
NativeCaptureExecute-->>ReviewHostRelay: return captured or closed status
ReviewHostRelay->>StatusReconciliation: reconcile capture outcome
Suggested reviewers: Merge Risk: ⚪ Minimal · up to Adds opt-in Pi execute capture routing while preserving the legacy path. The new outcomes are covered by tests, so no merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Self-repair contextThis PR is the second half of the same minimal compat fix as Highlights for maintainers reviewing this side:
Local validation: focused routing tests 22/22 and the full project suite 1923/1923. Happy to adjust to whatever contract shape upstream prefers for the provider metadata block. |
What
Add a provider execute vector for
review.capture-result + agent=pi + execute=trueso the host relay can drive one-correction admission retries for the Gentle AI issue #4406 fix and a matching refuter retry for #4422.Includes:
lib/review-host-relay.ts.lib/native-review-cli.ts(generalizecaptureProviderRoleto an execute vector; preserves verbatim tokens and decodes either artifact orreview-last-event-closure).extensions/gentle-ai.tsthat uses the new method; legacy materialize+submission path remains as compat.Validation
node --experimental-strip-types --test tests/review-host-relay-routing.test.ts: 22/22 pass.node --experimental-strip-types --test tests/*.test.ts: 1923/1923 pass (cancelled / skipped are pre-existing).Companion change
The companion provider metadata block lives in
dumbocan/gentle-ai#fix/pi-host-relay-admission-retry; the bound block is opt-in. Without it, the legacy 1-run forecast stays; with it, up to 2 host model runs.Summary by CodeRabbit